Return-Path: X-Original-To: apmail-directory-dev-archive@www.apache.org Delivered-To: apmail-directory-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C2B7210B3F for ; Wed, 23 Jul 2014 16:11:43 +0000 (UTC) Received: (qmail 57327 invoked by uid 500); 23 Jul 2014 16:11:43 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 57288 invoked by uid 500); 23 Jul 2014 16:11:43 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 57218 invoked by uid 99); 23 Jul 2014 16:11:43 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Jul 2014 16:11:43 +0000 Date: Wed, 23 Jul 2014 16:11:43 +0000 (UTC) From: "Emmanuel Lecharny (JIRA)" To: dev@directory.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (DIRAPI-197) When dumping a BindRequest, the password is exposed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DIRAPI-197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emmanuel Lecharny updated DIRAPI-197: ------------------------------------- Description: The BindRequestImpl.toString() metjod does print the password when in Simple mode (it's not the case when using SASL) : {code:java} if ( isSimple ) { sb.append( " Simple authentication : '" ).append( Strings.utf8ToString( credentials ) ) .append( '/' ).append( Strings.dumpBytes( credentials ) ).append( "'\n" ); } else { sb.append( " Sasl credentials\n" ); sb.append( " Mechanism :'" ).append( mechanism ).append( "'\n" ); if ( credentials == null ) { sb.append( " Credentials : null" ); } else { sb.append( " Credentials : (omitted-for-safety)" ); } {code} This is absolutely wrong... was: The BindRequestImpl.toString() metjod does print the password when in Simple mode (it's not the case when using SASL) : if ( isSimple ) { sb.append( " Simple authentication : '" ).append( Strings.utf8ToString( credentials ) ) .append( '/' ).append( Strings.dumpBytes( credentials ) ).append( "'\n" ); } else { sb.append( " Sasl credentials\n" ); sb.append( " Mechanism :'" ).append( mechanism ).append( "'\n" ); if ( credentials == null ) { sb.append( " Credentials : null" ); } else { sb.append( " Credentials : (omitted-for-safety)" ); } This is absolutely wrong... > When dumping a BindRequest, the password is exposed > --------------------------------------------------- > > Key: DIRAPI-197 > URL: https://issues.apache.org/jira/browse/DIRAPI-197 > Project: Directory Client API > Issue Type: Bug > Affects Versions: 1.0.0-M23 > Reporter: Emmanuel Lecharny > Priority: Blocker > Fix For: 1.0.0-M24 > > > The BindRequestImpl.toString() metjod does print the password when in Simple mode (it's not the case when using SASL) : > {code:java} > if ( isSimple ) > { > sb.append( " Simple authentication : '" ).append( Strings.utf8ToString( credentials ) ) > .append( '/' ).append( Strings.dumpBytes( credentials ) ).append( "'\n" ); > } > else > { > sb.append( " Sasl credentials\n" ); > sb.append( " Mechanism :'" ).append( mechanism ).append( "'\n" ); > if ( credentials == null ) > { > sb.append( " Credentials : null" ); > } > else > { > sb.append( " Credentials : (omitted-for-safety)" ); > } > {code} > This is absolutely wrong... -- This message was sent by Atlassian JIRA (v6.2#6252)