directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Lecharny (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DIRAPI-167) Make LdapConnection extend java.io.Closeable
Date Fri, 24 Jan 2014 22:32:38 GMT

    [ https://issues.apache.org/jira/browse/DIRAPI-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881493#comment-13881493
] 

Emmanuel Lecharny commented on DIRAPI-167:
------------------------------------------

Just go for it. As the comment says, there is no real reason for the close method to return
true or false.

> Make LdapConnection extend java.io.Closeable
> --------------------------------------------
>
>                 Key: DIRAPI-167
>                 URL: https://issues.apache.org/jira/browse/DIRAPI-167
>             Project: Directory Client API
>          Issue Type: Improvement
>            Reporter: lucas theisen
>            Priority: Minor
>         Attachments: DIRAPI-167-directory-client-api.patch
>
>
> This very small modification would allow us to leverage the Java 7 try-with-resources
feature.  The proper close method is already part of LdapConnection, so the modification is
extremely trivial.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message