Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Date: Tue, 26 Nov 2013 21:33:35 +0000 (UTC)
From: "Kevin Minder (JIRA)" <jira@apache.org>
To: dev@directory.apache.org
Message-ID: <JIRA.12681397.1385499503049.34022.1385501615076@arcas>
In-Reply-To: <JIRA.12681397.1385499503049@arcas>
References: <JIRA.12681397.1385499503049@arcas>
Subject: [jira] [Commented] (DIRSERVER-1920) Refactor
 DefaultDirectoryServiceFactory/DefaultDirectoryService for extensability
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DIRSERVER-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13833096#comment-13833096 ] 

Kevin Minder commented on DIRSERVER-1920:
-----------------------------------------

Motivation for doing this was to be able to create these two simple extension to eliminate some startup warnings 

The prevents an WARNing about the shutdown hook not being registered.
{code}
public class SimpleDirectoryServiceFactory extends DefaultDirectoryServiceFactory {

  protected DirectoryService createDirectoryService() {
    DirectoryService result;
    try {
      result = new SimpleDirectoryService();
    } catch( Exception e ) {
      throw new RuntimeException( e );
    }
    return result;
  }

}
{code}

This prevents startup warnings about the default admin password needing to be changed.
{code}
public class SimpleDirectoryService extends DefaultDirectoryService {

  public SimpleDirectoryService() throws Exception {
  }

  protected void showSecurityWarnings() throws Exception {
    // NoOp - This prevents confusing warnings from being output.
  }

}
{code}

> Refactor DefaultDirectoryServiceFactory/DefaultDirectoryService for extensability
> ---------------------------------------------------------------------------------
>
>                 Key: DIRSERVER-1920
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1920
>             Project: Directory ApacheDS
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 2.0.0-M15
>            Reporter: Kevin Minder
>         Attachments: DIRSERVER_1920__Refactor_DefaultDirectoryServiceFactory_DefaultDirectoryService_for_extensability.patch
>
>
> Enhance the extensibility and reusability of 
> apacheds/apacheds/core-annotations/src/main/java/org/apache/directory/server/core/factory/DefaultDirectoryServiceFactory.java
> apacheds/apacheds/core/src/main/java/org/apache/directory/server/core/DefaultDirectoryService.java
> For DefaultDirectoryServiceFactory create overridable methods for the creation of the DirectoryService and PartitionFactory.
> For DefaultDirectoryService make showSecuirtyWarnings to allow control for that behavior in subclasses.


--
This message was sent by Atlassian JIRA
(v6.1#6144)