directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Lecharny (JIRA)" <j...@apache.org>
Subject [jira] [Created] (DIRSERVER-1916) Don't drop 'top' from ObjectClass index, it's never present in the BTree
Date Tue, 12 Nov 2013 17:58:20 GMT
Emmanuel Lecharny created DIRSERVER-1916:
--------------------------------------------

             Summary: Don't drop 'top' from ObjectClass index, it's never present in the BTree
                 Key: DIRSERVER-1916
                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1916
             Project: Directory ApacheDS
          Issue Type: Improvement
    Affects Versions: 2.0.0-M15
            Reporter: Emmanuel Lecharny
             Fix For: 2.0.0-RC1


There is no need to call the partition specific code to drop the 'top' ObjectClass, it's not
managed by any index. The following code in AbstractBTreePartition need to be changed :

            // Update the ObjectClass index
            for ( Value<?> value : objectClass )
            {
                objectClassIdx.drop( value.getString(), id );
            }

This is the same thing for modifyAdd() :

            for ( Value<?> value : mods )
            {
                objectClassIdx.add( ( String ) value.getNormValue(), id );
            }

and modifyReplace() :

            for ( Value<?> value : entry.get( OBJECT_CLASS_AT ) )
            {
                objectClassIdx.drop( ( String ) value.getNormValue(), id );
            }

for modifyRemove() :

                for ( Value<?> objectClass : entry.get( OBJECT_CLASS_AT ) )
                {
                    objectClassIdx.drop( ( String ) objectClass.getNormValue(), id );
                }

and

                for ( Value<?> value : mods )
                {
                    objectClassIdx.drop( ( String ) value.getNormValue(), id );
                }




--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message