directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei Yan (JIRA)" <j...@apache.org>
Subject [jira] [Created] (DIRSERVER-1882) KertabEncoder.write() method should take into account the size of the entries list to determine the buffer size
Date Fri, 09 Aug 2013 20:38:48 GMT
Wei Yan created DIRSERVER-1882:
----------------------------------

             Summary: KertabEncoder.write() method should take into account the size of the
entries list to determine the buffer size
                 Key: DIRSERVER-1882
                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1882
             Project: Directory ApacheDS
          Issue Type: Bug
          Components: core
    Affects Versions: 2.0.0-M14
            Reporter: Wei Yan


Currently {{KeytabEncoder.write()}} always allocate 512 bytes as the buffer size, and doesn't
consider the entities list size.
{code}
ByteBuffer write( byte[] keytabVersion, List<KeytabEntry> entries )
{
  ByteBuffer buffer = ByteBuffer.allocate( 512 );
  putKeytabVersion( buffer, keytabVersion );
  putKeytabEntries( buffer, entries );
  buffer.flip();

  return buffer;
}
{code}

For each entity, {{KeytabEncoder.putKeytabEntry()}} allocates 100 buffer size.
{code}
private ByteBuffer putKeytabEntry( KeytabEntry entry )
{
  ByteBuffer buffer = ByteBuffer.allocate( 100 );
  ......
}
{code}

This mechanism fails when we create multiple principals in one keytab file. 

{{KeytabEncoder.write()}} method should take into account the size of entries list to determine
the buffer size. And a reasonable max size (100 currently) per entry must be determined.



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message