directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Lecharny (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DIRAPI-147) LdifEntry equals method does not compare entry attributes when changetype is None
Date Thu, 20 Jun 2013 19:26:20 GMT

    [ https://issues.apache.org/jira/browse/DIRAPI-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13689549#comment-13689549
] 

Emmanuel Lecharny commented on DIRAPI-147:
------------------------------------------

Good catch... I will apply the proposed change before releasing (I was just in the middle
of a release, this is a good thing you filled this JIRA before I started the vote !)
                
> LdifEntry equals method does not compare entry attributes when changetype is None
> ---------------------------------------------------------------------------------
>
>                 Key: DIRAPI-147
>                 URL: https://issues.apache.org/jira/browse/DIRAPI-147
>             Project: Directory Client API
>          Issue Type: Bug
>    Affects Versions: 1.0.0-M17
>         Environment: Windows, Linux
>            Reporter: Michael Moorman
>              Labels: Equals(), LdifEntry
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The equals() method of LdifEntry does not consider the inner entry's attributes when
ChangeType is not specified in the LDIF entry. 
> According to the the LDIF spec, when no changetype is specified in an LDIF entry, a changetype
"ADD" is to be assumed. 
> An easy fix would be, in the equals() method of LdifEntry.java, add case NONE to the
switch at:
>      // Check each different cases
>         switch ( changeType )
>         {
>             case None:          //<-- Add None case fall through
>             case Add:
>                  ......

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message