Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Received-SPF: pass (nike.apache.org: domain of elecharny@gmail.com designates
 209.85.215.175 as permitted sender)
Message-ID: <519E1CB0.3080507@gmail.com>
Date: Thu, 23 May 2013 15:42:08 +0200
From: =?UTF-8?B?RW1tYW51ZWwgTMOpY2hhcm55?= <elecharny@gmail.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
 rv:17.0) Gecko/20130509 Thunderbird/17.0.6
MIME-Version: 1.0
To: Apache Directory Developers List <dev@directory.apache.org>
Subject: Suspicius code in SyncReplRequestHandler
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hi Kiran,

while looking at Sonar reports
(https://analysis.apache.org/drilldown/violations), I found a weird
piece of code, which is likely ot be an error in SyncReplRequestHandler :

    private void sendContentFromLog( LdapSession session, SearchRequest
req, ReplicaEventLog clientMsgLog,
        String fromCsn )
        throws Exception
    {
    ...
                switch ( event )
                {
                    case ADD:
                        syncStateType = SyncStateTypeEnum.ADD;
                        break;

                    case MODIFY:
                        syncStateType = SyncStateTypeEnum.MODIFY;
                        break;

                    case MODDN:
                        syncStateType = SyncStateTypeEnum.MODDN;  
<<<<--------------- No break, so the syncStateType will switch to DELETE

                    case DELETE:
                        syncStateType = SyncStateTypeEnum.DELETE;
                        break;
                }

Am I correct to think that we must add a break ?

-- 
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com