Return-Path: X-Original-To: apmail-directory-dev-archive@www.apache.org Delivered-To: apmail-directory-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F1B96F7A1 for ; Thu, 11 Apr 2013 10:51:24 +0000 (UTC) Received: (qmail 40825 invoked by uid 500); 11 Apr 2013 10:51:24 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 40485 invoked by uid 500); 11 Apr 2013 10:51:23 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 39725 invoked by uid 99); 11 Apr 2013 10:51:22 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Apr 2013 10:51:22 +0000 Date: Thu, 11 Apr 2013 10:51:22 +0000 (UTC) From: "Kiran Ayyagari (JIRA)" To: dev@directory.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DIRSERVER-1822) Same password can be used multiple times, when SSHA is used for password hash. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DIRSERVER-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628833#comment-13628833 ] Kiran Ayyagari commented on DIRSERVER-1822: ------------------------------------------- Peter: Note that history checking works as expected when you send plain text password and please file a new bug (along with a test case would be awesome) if you find an issue with it. > Same password can be used multiple times, when SSHA is used for password hash. > ------------------------------------------------------------------------------ > > Key: DIRSERVER-1822 > URL: https://issues.apache.org/jira/browse/DIRSERVER-1822 > Project: Directory ApacheDS > Issue Type: Bug > Reporter: Peter Hmelak > Assignee: Kiran Ayyagari > > When using SSHA (salted SHA) for password hashing, no CONSTRAINT_VIOLATION (invalid reuse of password present in password history) is thrown, if new password is the same as one already in pwdHistory. > I believe current implementation just compares new password hash, with with ones stored in pwdHistory. > And because of new salt, no two hashes are ever a-like, even though passwords are the same. > Suggestion for fix: > *Every* salt stored in pwdHistory should be used, together with new password when creating password hashes, that are then compared with ones already stored in pwdHistory. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira