directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Blewitt (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DIRSTUDIO-810) Fullscreen plugin is /not/ under the Apache license
Date Thu, 03 May 2012 13:38:49 GMT

    [ https://issues.apache.org/jira/browse/DIRSTUDIO-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267428#comment-13267428
] 

Alex Blewitt commented on DIRSTUDIO-810:
----------------------------------------

Thanks, that's great.

BTW the empty bar is caused when the setToolbar is called on the NSWindow, which I tried to
capture with the windowOpened call. I think if you invoke the setToolbar on the main application
window you can turn it off.

This is how it's done in the main plugin:

https://github.com/bandlem/Fullscreen/blob/master/plugins/com.bandlem.eclipse.fullscreen.ui/src/com/bandlem/eclipse/fullscreen/ui/Startup.java

The 'Startup' is invoked by the Eclipse early startup mechanism (not sure if it's there in
the RCP app) which in turn gets the (already opened) window and calls the setFullScreen mode.

It should be kicked off by the plugin, which you've got in the plugin.xml:

14	   <extension
15	         point="org.eclipse.ui.startup">
16	      <startup
17	            class="org.apache.directory.studio.rcp.fullscreen.Startup"></startup>
18	   </extension>


http://help.eclipse.org/helios/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fextension-points%2Forg_eclipse_ui_startup.html

Since this is done by the workbench, you may not get this call injected if you're running
in a workbenchless RCP. You might need to find some other way of invoking the call once the
window has been created.

Hope that helps,

Alex
                
> Fullscreen plugin is /not/ under the Apache license
> ---------------------------------------------------
>
>                 Key: DIRSTUDIO-810
>                 URL: https://issues.apache.org/jira/browse/DIRSTUDIO-810
>             Project: Directory Studio
>          Issue Type: Bug
>    Affects Versions: 2.0.0-M4
>            Reporter: Alex Blewitt
>            Assignee: Pierre-Arnaud Marcelot
>            Priority: Blocker
>             Fix For: 2.0.0-M4, 2.0.0
>
>
> The fullscreen plugin was copied source-for-source from https://github.com/bandlem/Fullscreen/
under the Eclipse Public License.
> In revision 1229632 the source code was modified to indicate that it was released under
the Apache License. This is not the case.
> http://svn.apache.org/viewvc?view=revision&revision=1229632
> Please remove the Apache License from these files as I do not give permission for these
to be relicensed without prior consultation.
> The PLUGIN_ID in the Activator also needs to be renamed if you are doing this wholesale
to avoid problems where the real plugin may be available.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message