Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Received-SPF: pass (nike.apache.org: domain of ayaselcuk@gmail.com designates
 74.125.82.178 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4F61F89D.9010507@gmail.com>
References: <4F61F89D.9010507@gmail.com>
Date: Thu, 15 Mar 2012 19:38:17 -0700
Message-ID: 
 <CALhXAG19=j0GDu50b4eVGHhJnUta_8MR7F9O__zGd7Uw-vzdKA@mail.gmail.com>
Subject: Re: [TxnBranch] Serialization improvments
From: Selcuk AYA <ayaselcuk@gmail.com>
To: Apache Directory Developers List <dev@directory.apache.org>,
 elecharny@apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 15, 2012 at 7:11 AM, Emmanuel L=E9charny <elecharny@gmail.com> =
wrote:
> Hi,
> I continued to review the serialization of the DataChangeContainer
> structure, and found that we call writeObject() a couple of times :
> - in the ParentIdAndRdn class to serialize the UUID. It's easy to replace
> this call
> - in the IndexChange, for keys which are not String, byte[], Long. I adde=
d
> two cases : UUID and ParentIdAndRdn so that we can now use the
> read/writeExternal methods instead
>
> I also have a modifciation related to the Enums : I find the way Selcuk i=
s
> dealing with them way better than mine (ie, use the ordinal() method inst=
ead
> of inject values the way I did). So I reverted my changes to stick with w=
hat
> Selcuk did
>
> Those changes are purely internal and have no impact on the way the serve=
r
> works. Tests are passing.
>
> Here is the proposed patch : http://pastebin.com/UDRF3qPa

looks good, Would be good to add some test for deserializing these
objects as we dont have code to excersize them.

>
> --
> Regards,
> Cordialement,
> Emmanuel L=E9charny
> www.iktek.com
>

thanks
Selcuk