Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Received-SPF: pass (nike.apache.org: domain of pajbam@gmail.com designates
 74.125.82.178 as permitted sender)
Sender: Pierre-Arnaud Marcelot <pajbam@gmail.com>
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Apple Message framework v1257)
Subject: Re: LdapConnectionFactory is most certainly useless
From: Pierre-Arnaud Marcelot <pa@marcelot.net>
In-Reply-To: <4F5DC304.9000303@gmail.com>
Date: Mon, 12 Mar 2012 11:16:34 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <5074F8A7-1907-4F5E-960A-5A20812E9354@marcelot.net>
References: <4F5DC304.9000303@gmail.com>
To: "Apache Directory Developers List" <dev@directory.apache.org>,
 elecharny@apache.org

Hi Emmanuel,

I wasn't even aware of this class actually.

I'm not sure it's that useful.

+1.

Regards,
Pierre-Arnaud

On 12 mars 2012, at 10:33, Emmanuel L=E9charny wrote:

> Hi guys,
>=20
> I think that the LdapConnectionFactory class is not only useless, but =
it's also a source of problem.
>=20
> Methods such as :
>    /**
>     * Gets the core session connection.
>     *
>     * @return a connection based on the the CoreSession
>     */
>    public static LdapConnection getCoreSessionConnection()
>    {
>        try
>        {
>            Class<?> cl =3D Class.forName( =
"org.apache.directory.server.core.api.LdapCoreSessionConnection" );
>            return ( LdapConnection ) cl.newInstance();
>        }
>        catch ( Exception e )
>        {
>            throw new RuntimeException( e );
>        }
>    }
>=20
> Are too dependent on the class name, and should not be used. If we =
change its name, we could be in trouble.
>=20
> I suggest we get rid of this class and use the constructors instead.
>=20
> --=20
> Regards,
> Cordialement,
> Emmanuel L=E9charny
> www.iktek.com
>=20