directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Selcuk AYA <ayasel...@gmail.com>
Subject Re: svn commit: r1300690 - in /directory/apacheds/branches/apacheds-txns: core-api/src/main/java/org/apache/directory/server/core/api/log/ core-api/src/main/java/org/apache/directory/server/core/api/txn/ core-api/src/main/java/org/apache/directory/se
Date Wed, 14 Mar 2012 21:52:01 GMT
HI All,
Sorry for the earlier email. I think I owe some explaination on my
part. The reason for my request is purely technical, does not aim at
oss spirit or any other spirit for that matter:
* There are quite a number of files the txn branch is touching.
* There is no file ownership or review process.

combined with the timing limitation, it becomes hard for me to track
all changes and cleanup if necessary. When I am doing my changes and
need to change some existing stuff, I usually try to find the guy who
wrote the code and get an ack from him and this usually helps a lot
because even things that look stupid might have some reason to be
there. Please do the same while changing the txn branch.If this
process is followed, we wont have to discuss spirit hurting through
reverting code.

thanks
Selcuk

On Wed, Mar 14, 2012 at 2:48 PM, Alex Karasulu <akarasulu@apache.org> wrote:
>
>
> On Wed, Mar 14, 2012 at 10:41 PM, Kiran Ayyagari <kayyagari@apache.org>
> wrote:
>>
>> Selcuk,
>>
>>    I have seen you asking several times on this list for reverting
>> commits,
>>    this seems to be a bit derogatory in OSS spirit and team work.
>
>
> It can certainly be misinterpreted this way. I think we just need more
> communication about why one may need a revert.
>
> Revert requests are OK. There's nothing wrong with that and any committer
> can veto a change but they just need to provide reasons. I think we just
> need to help people understand this.
>
> Selcuk I'm sure meant no harm and can provide more reasoning.
>
>>
>>    Go ahead and make your changes on top of these if you wish to apply
>>    your fix, commits need not be reverted for this.
>>
>
> That's also another option but let's just communicate about whatever
> difficulties or problems a commit might introduce. If someone is having
> problems as a result of commits let's get those reasons out there on the
> list.
>
> I have a feeling the code is starting to move before some of the work can be
> finished on it and that might produce discomfort. But we're not mind readers
> so we need to communicate this.
>
>>
>> On Thu, Mar 15, 2012 at 1:39 AM, Selcuk AYA <ayaselcuk@gmail.com> wrote:
>> > please revert this commit.
>> >
>
>
> --
> Best Regards,
> -- Alex
>

Mime
View raw message