Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Received-SPF: pass (nike.apache.org: domain of akarasulu@gmail.com designates
 74.125.82.44 as permitted sender)
MIME-Version: 1.0
Sender: akarasulu@gmail.com
In-Reply-To: <20120202225908.A31382388900@eris.apache.org>
References: <20120202225908.A31382388900@eris.apache.org>
Date: Sat, 4 Feb 2012 00:09:01 +0200
Message-ID: 
 <CADwPi+FQCZkSZuXsAhTDze3tq_CKUcqZsSC+2Zoikx1L0MjELw@mail.gmail.com>
Subject: Re: svn commit: r1239907 - in /directory/shared/trunk/ldap/model/src:
 main/java/org/apache/directory/shared/ldap/model/name/Rdn.java
 test/java/org/apache/directory/shared/ldap/model/name/RdnTest.java
From: Alex Karasulu <akarasulu@apache.org>
To: dev@directory.apache.org
Content-Type: multipart/alternative; boundary=0016e6d77d4462e65e04b8168f78

--0016e6d77d4462e65e04b8168f78
Content-Type: text/plain; charset=ISO-8859-1

On Fri, Feb 3, 2012 at 12:59 AM, <elecharny@apache.org> wrote:

> Author: elecharny
> Date: Thu Feb  2 22:59:08 2012
> New Revision: 1239907
>
> URL: http://svn.apache.org/viewvc?rev=1239907&view=rev
> Log:
> Fix DIRAPI-76 : new Rdn( "A=a,B=b" ) now throws an LdapInvalidDnException
>
>
Should the exception not be ... LdapInvalidNameComponent (we can create one
if it does not exist).

Reason I say this is that the whole issue with the non-intuitive
constructor was that the API user was thinking the argument can be a
multi-component relative distinguished name or a DN. LdapInvalidDnException
might not fit here and it might make the user think they have to use a DN
rather than a single name component.

WDYT?

-- 
Best Regards,
-- Alex

--0016e6d77d4462e65e04b8168f78
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<br><br><div class=3D"gmail_quote">On Fri, Feb 3, 2012 at 12:59 AM,  <span =
dir=3D"ltr">&lt;<a href=3D"mailto:elecharny@apache.org">elecharny@apache.or=
g</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margi=
n:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: elecharny<br>
Date: Thu Feb =A02 22:59:08 2012<br>
New Revision: 1239907<br>
<br>
URL: <a href=3D"http://svn.apache.org/viewvc?rev=3D1239907&amp;view=3Drev" =
target=3D"_blank">http://svn.apache.org/viewvc?rev=3D1239907&amp;view=3Drev=
</a><br>
Log:<br>
Fix DIRAPI-76 : new Rdn( &quot;A=3Da,B=3Db&quot; ) now throws an LdapInvali=
dDnException<br><br></blockquote><div><br></div><div>Should the exception n=
ot be ... LdapInvalidNameComponent (we can create one if it does not exist)=
.</div>
<div><br></div><div>Reason I say this is that the whole issue with the non-=
intuitive constructor was that the API user was thinking the argument can b=
e a multi-component relative distinguished name or a DN. LdapInvalidDnExcep=
tion might not fit here and it might make the user think they have to use a=
 DN rather than a single name component.</div>
<div><br></div><div>WDYT?</div><div><br></div></div>-- <br><div>Best Regard=
s,</div><div>-- Alex</div><br>

--0016e6d77d4462e65e04b8168f78--