Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Received-SPF: pass (athena.apache.org: domain of pajbam@gmail.com designates
 74.125.82.42 as permitted sender)
Sender: Pierre-Arnaud Marcelot <pajbam@gmail.com>
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Apple Message framework v1251.1)
Subject: Re: svn commit: r1233924 -
 /directory/apacheds/trunk/protocol-kerberos/src/main/java/org/apache/directory/server/kerberos/kdc/KdcServer.java
From: Pierre-Arnaud Marcelot <pa@marcelot.net>
In-Reply-To: 
 <CABzFU-ckC-W=5FkoArxRRyswU_ydmf0-Qi0iqVDJodg0nknH=w@mail.gmail.com>
Date: Sat, 21 Jan 2012 12:58:56 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <8006554B-9CB6-4E30-82DD-48B16587C5BE@marcelot.net>
References: <20120120142703.19AC4238897D@eris.apache.org>
 <3644122D-53BE-4AC4-9243-D1A5B8A366B7@marcelot.net>
 <CABzFU-ckC-W=5FkoArxRRyswU_ydmf0-Qi0iqVDJodg0nknH=w@mail.gmail.com>
To: "Apache Directory Developers List" <dev@directory.apache.org>

No problem, Kiran. ;)

Build success now.

Regards,
Pierre-Arnaud

On 21 janv. 2012, at 12:05, Kiran Ayyagari wrote:

> my bad, forgot to commit the test fixes, now done at rev. 1234302.
> thanks Pierre-Arnaud for the heads up, appreciate it
>=20
> On Fri, Jan 20, 2012 at 9:54 PM, Pierre-Arnaud Marcelot =
<pa@marcelot.net> wrote:
>> Kiran, Aleksander,
>>=20
>> This changes makes the build fail on my system.
>>=20
>> Here's the error I get:
>> Failed tests:   =
testAes128Configuration(org.apache.directory.server.kerberos.protocol.Auth=
enticationEncryptionTypeTest): KDC has no support for encryption type =
expected:<KDC has no support for encryption type> but was:<Integrity =
check on decrypted field failed>
>>=20
>> Was it passing fine on your systems?
>>=20
>> Thanks,
>> Pierre-Arnaud
>>=20
>>=20
>> On 20 janv. 2012, at 15:27, kayyagari@apache.org wrote:
>>=20
>>> Author: kayyagari
>>> Date: Fri Jan 20 14:27:02 2012
>>> New Revision: 1233924
>>>=20
>>> URL: http://svn.apache.org/viewvc?rev=3D1233924&view=3Drev
>>> Log:
>>> o applied the patch from Aleksander Adamowski, thank you
>>>=20
>>> Modified:
>>>    =
directory/apacheds/trunk/protocol-kerberos/src/main/java/org/apache/direct=
ory/server/kerberos/kdc/KdcServer.java
>>>=20
>>> Modified: =
directory/apacheds/trunk/protocol-kerberos/src/main/java/org/apache/direct=
ory/server/kerberos/kdc/KdcServer.java
>>> URL: =
http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-kerberos/sr=
c/main/java/org/apache/directory/server/kerberos/kdc/KdcServer.java?rev=3D=
1233924&r1=3D1233923&r2=3D1233924&view=3Ddiff
>>> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>>> --- =
directory/apacheds/trunk/protocol-kerberos/src/main/java/org/apache/direct=
ory/server/kerberos/kdc/KdcServer.java (original)
>>> +++ =
directory/apacheds/trunk/protocol-kerberos/src/main/java/org/apache/direct=
ory/server/kerberos/kdc/KdcServer.java Fri Jan 20 14:27:02 2012
>>> @@ -85,7 +85,7 @@ public class KdcServer extends Directory
>>>=20
>>>     /** The default encryption types */
>>>     private static final String[] DEFAULT_ENCRYPTION_TYPES =3D new =
String[]
>>> -        { "des-cbc-md5" };
>>> +           { "aes128-cts-hmac-sha1-96", "des3-cbc-sha1-kd", =
"des-cbc-md5" };
>>>=20
>>>     /** The default for allowing empty addresses */
>>>     private static final boolean DEFAULT_EMPTY_ADDRESSES_ALLOWED =3D =
true;
>>> @@ -557,12 +557,11 @@ public class KdcServer extends Directory
>>>=20
>>>         for ( String enc : encryptionTypeStrings )
>>>         {
>>> -            for ( EncryptionType type : =
EncryptionType.getEncryptionTypes() )
>>> +            EncryptionType type =3D EncryptionType.getByName(enc);
>>> +
>>> +            if ( ! EncryptionType.UNKNOWN.equals(type) )
>>>             {
>>> -                if ( type.getName().equalsIgnoreCase( enc ) )
>>> -                {
>>> -                    encryptionTypes.add( type );
>>> -                }
>>> +                encryptionTypes.add( type );
>>>             }
>>>         }
>>>     }
>>>=20
>>>=20
>>=20
>=20
>=20
>=20
> --=20
> Kiran Ayyagari