From dev-return-39716-apmail-directory-dev-archive=directory.apache.org@directory.apache.org Thu Dec 1 10:26:59 2011 Return-Path: X-Original-To: apmail-directory-dev-archive@www.apache.org Delivered-To: apmail-directory-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2440076AE for ; Thu, 1 Dec 2011 10:26:59 +0000 (UTC) Received: (qmail 53530 invoked by uid 500); 1 Dec 2011 10:26:58 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 53473 invoked by uid 500); 1 Dec 2011 10:26:58 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 53466 invoked by uid 99); 1 Dec 2011 10:26:58 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Dec 2011 10:26:58 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of pajbam@gmail.com designates 209.85.214.50 as permitted sender) Received: from [209.85.214.50] (HELO mail-bw0-f50.google.com) (209.85.214.50) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Dec 2011 10:26:52 +0000 Received: by bkbzx1 with SMTP id zx1so2542177bkb.37 for ; Thu, 01 Dec 2011 02:26:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:content-type:mime-version:subject:from:in-reply-to:date :content-transfer-encoding:message-id:references:to:x-mailer; bh=k1ieLG9xecmT6pkpYfwPl84PTds6ApK6xBt674LNitc=; b=jJ63e2YI0l93YCZZuz7Jvn3+ofI8hSNpY7aOQiIEIx2qoX1ebK/FN9kNbgN+g6AtJP eHdaV9BIq6TfIj8oOjexgprMohQHdN7vr40rOw2WNZI1rd7Oliij6Eb9J3Q6dR+xh9fg pu/g5XF/FvSIeiIe8tMSdsE7tIYPXKn5uKbn8= Received: by 10.205.127.140 with SMTP id ha12mr532881bkc.51.1322735190435; Thu, 01 Dec 2011 02:26:30 -0800 (PST) Received: from [10.0.1.2] (def92-4-82-225-58-213.fbx.proxad.net. [82.225.58.213]) by mx.google.com with ESMTPS id hw14sm10313095bkc.16.2011.12.01.02.26.26 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 01 Dec 2011 02:26:27 -0800 (PST) Sender: Pierre-Arnaud Marcelot Content-Type: text/plain; charset=iso-8859-1 Mime-Version: 1.0 (Apple Message framework v1251.1) Subject: Re: Partition.bind : do we need it ? From: Pierre-Arnaud Marcelot In-Reply-To: <4ED7521E.5030601@gmail.com> Date: Thu, 1 Dec 2011 11:26:24 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <7C8F2B25-9C28-4A88-8999-24158CF64B70@marcelot.net> References: <4ED7521E.5030601@gmail.com> To: "Apache Directory Developers List" , elecharny@apache.org X-Mailer: Apple Mail (2.1251.1) On 1 d=E9c. 2011, at 11:08, Emmanuel Lecharny wrote: > Hi guys, >=20 > following the last mails from Jason, it seems that having a bind() = method in the Partition interface is a bt misleading. We most certainly = don't need it, and currently, it does nothing. Moreover, the = authenticationInterceptor does *not* call next.bind(), so there is no = way the bind operation can percolate through the chain to the Partition. >=20 > We discussed about this with Pierre Arnaud this morning, and I removed = the method from the Partitio interface, t has no impact on the code so = far (it's an experiment, I haven't committed anything yet). >=20 > So do you think we can get rid of the bind() method in the Partition = interface ? Analyzing the current situation and implementations, it looks like this = method isn't really used. Its only real implementation, in AbstractBTreePartition, throws an = LdapAuthenticationNotSupportedException and other implementations, in = DefaultPartitionNexus and SchemaPartition, are only following the call = to the wrapped partition. It really seems useless to me. +1 for the removal.=20 Regards, Pierre-Arnaud > --=20 > Regards, > Cordialement, > Emmanuel L=E9charny > www.iktek.com >=20