Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Received-SPF: pass (nike.apache.org: domain of ayaselcuk@gmail.com designates
 209.85.160.178 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4EAAECA3.9050808@gmail.com>
References: <20111027092424.05BC62388900@eris.apache.org>
	<CALhXAG2Bq1f1pY4E3VRQnWZa+SSVwsszu505sGG-iGNPr5WiXw@mail.gmail.com>
	<4EAAECA3.9050808@gmail.com>
Date: Sat, 29 Oct 2011 09:23:13 +0300
Message-ID: 
 <CALhXAG2omLqH3YCO+2z9HTn_fR0UHKCQLvzLZRkKSKWq6gDnjw@mail.gmail.com>
Subject: Re: svn commit: r1189688 - in
 /directory/apacheds/branches/apacheds-txns:
 core-api/src/main/java/org/apache/directory/server/core/log/
 core/src/main/java/org/apache/directory/server/core/log/
From: Selcuk AYA <ayaselcuk@gmail.com>
To: Apache Directory Developers List <dev@directory.apache.org>,
 elecharny@apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 28, 2011 at 8:55 PM, Emmanuel Lecharny <elecharny@gmail.com> wr=
ote:
> On 10/28/11 9:46 AM, Selcuk AYA wrote:
>>
>> On Thu, Oct 27, 2011 at 12:24 PM,<elecharny@apache.org> =A0wrote:
>>>
>>> Author: elecharny
>>> Date: Thu Oct 27 09:24:23 2011
>>> New Revision: 1189688
>>>
>>> URL: http://svn.apache.org/viewvc?rev=3D1189688&view=3Drev
>>> Log:
>>> o Added a Log.begingScan() method with no argument
>>
>> log files are deleted as minneeded log file is advances. So this
>> method should get a consistent copy of the min needed log file or min
>> existing log file and should start scanning from there.
>
> yeah, I realized that this afternoon as I was working on the code. Should=
 I
> fix the method ?
I am OK both ways. If you have time, please go ahead. Also you were
talking about a bug you hit during a test, please upload a test case
for it so that I can take a look.

>>
>>> o Renamed LogScanner to LogScannerInternal
>>> o Made fields private
>>
>> I think it is unnecessary to make internal private class fields
>> private. As I mentioned before, I use these little inner classes to
>> group data together and I access them directly.
>
> This is just a protection. Later, if you make this inner class a plain
> class, you will have to make the field private.
>
>
> --
> Regards,
> Cordialement,
> Emmanuel L=E9charny
> www.iktek.com
>
>

regards,
Selcuk