Return-Path: X-Original-To: apmail-directory-dev-archive@www.apache.org Delivered-To: apmail-directory-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7402E77FE for ; Wed, 26 Oct 2011 16:32:49 +0000 (UTC) Received: (qmail 50863 invoked by uid 500); 26 Oct 2011 16:32:49 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 50803 invoked by uid 500); 26 Oct 2011 16:32:49 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 50796 invoked by uid 99); 26 Oct 2011 16:32:49 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Oct 2011 16:32:49 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of ayaselcuk@gmail.com designates 209.85.215.178 as permitted sender) Received: from [209.85.215.178] (HELO mail-ey0-f178.google.com) (209.85.215.178) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Oct 2011 16:32:42 +0000 Received: by eye13 with SMTP id 13so1794288eye.37 for ; Wed, 26 Oct 2011 09:32:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=/IOJ8/oxXLUmdzSfW9A4KjQh/lOJCYv6U3FUqjjmazQ=; b=gLmKuKrsrUiB7exAg76hcHoWdSHpo5w2Hyss8TC9uG+rVcLveUPzWTXvBk6CEnPUkw pMcGkivr+reIkwEDU4VsQtJV4N4cmT3+/PClq9s/tMPgZuNr8gmV1BZqOoX9JGYkYeMx BM8gpxihXS1AbugvXdiwh7lKs+RxoYj+TEssA= MIME-Version: 1.0 Received: by 10.182.73.33 with SMTP id i1mr5463236obv.67.1319646741918; Wed, 26 Oct 2011 09:32:21 -0700 (PDT) Received: by 10.182.15.72 with HTTP; Wed, 26 Oct 2011 09:32:21 -0700 (PDT) In-Reply-To: <4EA6B20B.20703@gmail.com> References: <4EA6B20B.20703@gmail.com> Date: Wed, 26 Oct 2011 19:32:21 +0300 Message-ID: Subject: Re: LogScanner questions From: Selcuk AYA To: Apache Directory Developers List , elecharny@apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org On Tue, Oct 25, 2011 at 3:56 PM, Emmanuel Lecharny wr= ote: > Hi, > > I see that the readLogRecord() method tries to read some data from the lo= g > file, with a specified size. It calls the LogFileManager.read( buffer, > offset, size ) method, which reads the exect buber of bytes required, or > throws an exception. So is it a good idea to return the number of read by= tes > ? retruning the number of bytes read should not be necessary and it is not used anywhere. I will remove it. > > -- > Regards, > Cordialement, > Emmanuel L=E9charny > www.iktek.com > >