directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Lecharny <>
Subject Re: svn commit: r1189688 - in /directory/apacheds/branches/apacheds-txns: core-api/src/main/java/org/apache/directory/server/core/log/ core/src/main/java/org/apache/directory/server/core/log/
Date Fri, 28 Oct 2011 17:55:47 GMT
On 10/28/11 9:46 AM, Selcuk AYA wrote:
> On Thu, Oct 27, 2011 at 12:24 PM,<>  wrote:
>> Author: elecharny
>> Date: Thu Oct 27 09:24:23 2011
>> New Revision: 1189688
>> URL:
>> Log:
>> o Added a Log.begingScan() method with no argument
> log files are deleted as minneeded log file is advances. So this
> method should get a consistent copy of the min needed log file or min
> existing log file and should start scanning from there.

yeah, I realized that this afternoon as I was working on the code. 
Should I fix the method ?
>> o Renamed LogScanner to LogScannerInternal
>> o Made fields private
> I think it is unnecessary to make internal private class fields
> private. As I mentioned before, I use these little inner classes to
> group data together and I access them directly.

This is just a protection. Later, if you make this inner class a plain 
class, you will have to make the field private.

Emmanuel L├ęcharny

View raw message