directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Felix Knecht <fel...@apache.org>
Subject Re: Uncheck file operations
Date Sat, 01 Oct 2011 16:42:00 GMT
On 10/01/2011 06:32 PM, Emmanuel Lecharny wrote:
> On 10/1/11 4:32 PM, Felix Knecht wrote:
>> Hi
>>
>> ApacheDs and probably also Shared has in many locations file
>> operations like File.[delete|mkdir|...] where the return value
>> (true|false) is unchecked. In Java-1.7 exists static methods for this
>> in java.nio.file.Files [1] where an IOException is thrown if the
>> operation fails, in < Java-1.7 a SecurityException is thrown only in
>> some special cases and in all other cases the return value is 'false'
>> and no Exception is thrown [2]. IMO we should check the return value
>> of these operations and throw an IOException if the file/directory
>> couldn't be created/delete/renamed ...
>> If wanted I'll create a JIRA and go for it.
> Go for it, but keep in mind we still have to support Java 6...

I thought about some like which should be Java 6 compatible:

if (!File.delete()) {
   throw new IOException("Could not delete file ...");
}


>
> Thanks !
>
>


Mime
View raw message