Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Received-SPF: pass (nike.apache.org: domain of elecharny@gmail.com designates
 209.85.161.50 as permitted sender)
Message-ID: <4E4BECE7.1060108@gmail.com>
Date: Wed, 17 Aug 2011 18:31:35 +0200
From: Emmanuel Lecharny <elecharny@gmail.com>
Reply-To: elecharny@apache.org
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6;
 rv:5.0) Gecko/20110624 Thunderbird/5.0
MIME-Version: 1.0
To: Apache Directory Developers List <dev@directory.apache.org>
Subject: Cursor hierarchy under review
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi guys,

as Stefan has found a serious issue in the way we handle JdbmIndex 
(https://issues.apache.org/jira/browse/DIRSERVER-1642), I'm spending a 
few hours reviewing the Cursor hierarchy. There is plenty of room for 
improvements, and I have started to clean up a bit what is obvious, like 
renaming some classes to be consistent with our current code (for 
instance, we have no more ServerEntry class, so the 
ServerEntryCursorAdaptor has been renamed to EntryCursorAdaptor. I'm 
also migrating some commmon methods to the existig Abstract class when 
useful). I'm also adding some missing Javadoc.

I will continuedoing that the next two days, and I hope we can get rid 
of DIRSERVER-1642 and 
https://issues.apache.org/jira/browse/DIRSERVER-1458 (an issue I have 
created one year ago. Don't get me wrong : its title is certainly 
abrupt, but back them, I wasn't able to understand anything about this 
hierarchy. I would rather say that the cursor API generic usage could be 
improved...)

Keep tuned.

Thanks !

-- 
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com