Return-Path: X-Original-To: apmail-directory-dev-archive@www.apache.org Delivered-To: apmail-directory-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1D0DD71E8 for ; Wed, 20 Jul 2011 22:24:54 +0000 (UTC) Received: (qmail 26358 invoked by uid 500); 20 Jul 2011 22:24:53 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 26297 invoked by uid 500); 20 Jul 2011 22:24:53 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 26290 invoked by uid 99); 20 Jul 2011 22:24:52 -0000 Received: from minotaur.apache.org (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jul 2011 22:24:52 +0000 Received: from localhost (HELO emmanuel-lecharnys-MacBook-Pro.local) (127.0.0.1) (smtp-auth username elecharny, mechanism plain) by minotaur.apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jul 2011 22:24:52 +0000 Message-ID: <4E2755AD.6010508@apache.org> Date: Thu, 21 Jul 2011 00:24:45 +0200 From: =?UTF-8?B?RW1tYW51ZWwgTMOpY2hhcm55?= Reply-To: elecharny@apache.org Organization: The Apache Software Foundation User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:5.0) Gecko/20110624 Thunderbird/5.0 MIME-Version: 1.0 To: Apache Directory Developers List Subject: Re: Partitions Heads up : resent with correct formating for the hierarchies References: <4E270C91.3020205@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7/20/11 8:50 PM, Stefan Seelmann wrote: > Sounds all reasonable. The only thing that bugs me is that the > hierarchy gets bigger, I think of "Composition over Inheritance". But > I have no real argument against your proposal. I have still to think about the PartitionNexus interface, I'm not 100% convinced it should extend the Partition interface. > > One open question: in your final class hierarchy there are two > abstract classes in a row: AbstractBTreePartition and > AbstractXdbmPartition: I think it should be possbile to merge them > too, isn't it? yes, but atm, I'm trying to get the tests passing before going any further. There are some few things I haven't talked about : - SchemaService class should disappear. It's useless - I was thinking about merging the initialize() and doInit() methods - all of what I'm currently doing has one purpose : being able to simplify the init phase in order to be ready for OSGi -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com