From dev-return-38632-apmail-directory-dev-archive=directory.apache.org@directory.apache.org Sun Jul 24 10:22:30 2011 Return-Path: X-Original-To: apmail-directory-dev-archive@www.apache.org Delivered-To: apmail-directory-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ABF1B74EC for ; Sun, 24 Jul 2011 10:22:30 +0000 (UTC) Received: (qmail 61913 invoked by uid 500); 24 Jul 2011 10:22:29 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 61695 invoked by uid 500); 24 Jul 2011 10:22:21 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 61687 invoked by uid 99); 24 Jul 2011 10:22:17 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 24 Jul 2011 10:22:17 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of ayyagarikiran@gmail.com designates 209.85.220.178 as permitted sender) Received: from [209.85.220.178] (HELO mail-vx0-f178.google.com) (209.85.220.178) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 24 Jul 2011 10:22:09 +0000 Received: by vxk12 with SMTP id 12so2983005vxk.37 for ; Sun, 24 Jul 2011 03:21:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=oTAeBioP7p/tiri3Dfp4dC44mO/wpjc/c9R6932l7D8=; b=fzZXbTkcam1AmLGMgltZaFN9Wof1nhx9lBDd490ynb7N1wYNvc3rnPoBDMzsZldDso UDmq+wcxI+4CRkcO/ugSce4vxAvKHJCu9/Y2fcAvVxfnnkpLJs+eMV1zMLloV5nUrKH8 wWMoJPhI7m2pm27ehIXlNy9laLShX9BiMuPYw= MIME-Version: 1.0 Received: by 10.52.24.47 with SMTP id r15mr3189281vdf.110.1311502908723; Sun, 24 Jul 2011 03:21:48 -0700 (PDT) Sender: ayyagarikiran@gmail.com Received: by 10.52.184.162 with HTTP; Sun, 24 Jul 2011 03:21:47 -0700 (PDT) Received: by 10.52.184.162 with HTTP; Sun, 24 Jul 2011 03:21:47 -0700 (PDT) In-Reply-To: References: <20110723203204.D3BAD2388994@eris.apache.org> <4E2B3701.905@gmail.com> Date: Sun, 24 Jul 2011 15:51:47 +0530 X-Google-Sender-Auth: Mgp-hbYfmxAA9uBJ_KKllir4RMg Message-ID: Subject: Re: svn commit: r1150216 - /directory/apacheds/trunk/service-builder/src/main/java/org/apache/directory/server/config/ServiceBuilder.java From: Kiran Ayyagari To: Apache Directory Developers List Content-Type: multipart/alternative; boundary=20cf307f37b8ff106304a8ce1058 X-Virus-Checked: Checked by ClamAV on apache.org --20cf307f37b8ff106304a8ce1058 Content-Type: text/plain; charset=ISO-8859-1 The right place is ApacheDsService On 24-Jul-2011 2:03 PM, "Stefan Seelmann" wrote: On Sat, Jul 23, 2011 at 11:02 PM, Emmanuel Lecharny wrote: > On 7/23/11 10:32 ... I just checked Pierre-Arnaud's commit. He added the code to create the SchemaPartition to ApacheDsService class while I added the code to ServiceBuilder class. I'm not sure what's the better place. > Btw, I'm wondering why we don't have a test that check that the server is > correctly started... ... Yes, that would be good. --20cf307f37b8ff106304a8ce1058 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

The right place is ApacheDsService

On 24-Jul-2011 2:03 PM, "Stefan Seelmann&= quot; <seelmann@apache.org>= ; wrote:

On Sat, Jul 23, 2011 at 11:02 PM= , Emmanuel Lecharny <elecharny@gm= ail.com> wrote:
> On 7/23/11 10:32 ...

I just checked Pierre-Arnaud's comm= it. He added the code to create the
SchemaPartition to ApacheDsService class while I added the code to
ServiceBuilder class. I'm not sure what's the better place.


> Btw, I'm wondering why we don't= have a test that check that the server is
> correctly started...
= ...

Yes, that would be good.

--20cf307f37b8ff106304a8ce1058--