directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kiran Ayyagari <kayyag...@apache.org>
Subject Re: svn commit: r1129630 - /directory/apacheds/trunk/server-integ/src/test/java/org/apache/directory/server/replication/ClientServerReplicationIT.java
Date Fri, 03 Jun 2011 06:27:55 GMT
On Thu, Jun 2, 2011 at 11:02 PM, Alex Karasulu <akarasulu@apache.org> wrote:
> This did not make it to the list. --Alex
>
> On Thu, Jun 2, 2011 at 4:32 PM, Alex Karasulu <akarasulu@apache.org> wrote:
>>
>> Is there any way we can avoid using timing dependent code like these sleep calls?
Can't we enable a feedback mechanism where setting some variable drives controlling this process?
this test like many other integration tests involves a running
server(s) in network mode and the scenario under testing is highly
time bound, i.e there
*will* be delays before the data gets replicated and the test has to
be written based on the reasonable time limit.
Though not straight forward, feedback based mechanism can be added but
that requires a lot of scaffolding based on persistent search/event
listeners
>> If something is not readily clear as a solution maybe we can just create a JIRA about
this so we can track it and handle it later.
>>
>> If the machine is overloaded this will take longer and you don't know just how fast
the machine will work.
>> Regards,
>> Alex
>>
>> On Tue, May 31, 2011 at 2:22 PM, <kayyagari@apache.org> wrote:
>>>
>>> Author: kayyagari
>>> Date: Tue May 31 11:22:51 2011
>>> New Revision: 1129630
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1129630&view=rev
>>> Log:
>>> o increased the sleep time to let the consumer sync after reboot before performing
any checks
>>>
>>> Modified:
>>>    directory/apacheds/trunk/server-integ/src/test/java/org/apache/directory/server/replication/ClientServerReplicationIT.java
>>>
>>> Modified: directory/apacheds/trunk/server-integ/src/test/java/org/apache/directory/server/replication/ClientServerReplicationIT.java
>>> URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/server-integ/src/test/java/org/apache/directory/server/replication/ClientServerReplicationIT.java?rev=1129630&r1=1129629&r2=1129630&view=diff
>>> ==============================================================================
>>> --- directory/apacheds/trunk/server-integ/src/test/java/org/apache/directory/server/replication/ClientServerReplicationIT.java
(original)
>>> +++ directory/apacheds/trunk/server-integ/src/test/java/org/apache/directory/server/replication/ClientServerReplicationIT.java
Tue May 31 11:22:51 2011
>>> @@ -213,7 +213,7 @@ public class ClientServerReplicationIT
>>>
>>>         startConsumer();
>>>
>>> -        Thread.sleep( 2000 );
>>> +        Thread.sleep( 5000 );
>>>         assertFalse( consumerSession.exists( deletedUserDn ) );
>>>         waitAndCompareEntries( addedUserDn );
>>>     }
>>>
>>>
>>
>



-- 
Kiran Ayyagari

Mime
View raw message