directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Karasulu <akaras...@apache.org>
Subject Re: svn commit: r1135472 - /directory/apacheds/trunk/xdbm-partition/src/main/java/org/apache/directory/server/xdbm/AbstractStore.java
Date Wed, 15 Jun 2011 00:45:02 GMT
-1

Please revert these changes. Sufficient consideration has not been
given to these matters which have been around for years. We need more
time to discuss these matters.

Thanks,
Alex

On Tue, Jun 14, 2011 at 1:52 PM,  <elecharny@apache.org> wrote:
> Author: elecharny
> Date: Tue Jun 14 10:52:21 2011
> New Revision: 1135472
>
> URL: http://svn.apache.org/viewvc?rev=1135472&view=rev
> Log:
> Removed the Cycle detection check in the addAliasIndices() method.
>
> Modified:
>    directory/apacheds/trunk/xdbm-partition/src/main/java/org/apache/directory/server/xdbm/AbstractStore.java
>
> Modified: directory/apacheds/trunk/xdbm-partition/src/main/java/org/apache/directory/server/xdbm/AbstractStore.java
> URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/xdbm-partition/src/main/java/org/apache/directory/server/xdbm/AbstractStore.java?rev=1135472&r1=1135471&r2=1135472&view=diff
> ==============================================================================
> --- directory/apacheds/trunk/xdbm-partition/src/main/java/org/apache/directory/server/xdbm/AbstractStore.java
(original)
> +++ directory/apacheds/trunk/xdbm-partition/src/main/java/org/apache/directory/server/xdbm/AbstractStore.java
Tue Jun 14 10:52:21 2011
> @@ -1792,32 +1792,6 @@ public abstract class AbstractStore<E, I
>         normalizedAliasTargetDn = new Dn( schemaManager, aliasTarget );
>
>         /*
> -         * Check For Cycles
> -         *
> -         * Before wasting time to lookup more values we check using the target
> -         * dn to see if we have the possible formation of an alias cycle.  This
> -         * happens when the alias refers back to a target that is also a
> -         * relative of the alias entry.  For detection we test if the aliased
> -         * entry Dn starts with the target Dn.  If it does then we know the
> -         * aliased target is a relative and we have a perspecitive cycle.
> -         */
> -        if ( aliasDn.isDescendantOf( normalizedAliasTargetDn ) )
> -        {
> -            if ( aliasDn.equals( normalizedAliasTargetDn ) )
> -            {
> -                String msg = I18n.err( I18n.ERR_223 );
> -                LdapAliasDereferencingException e = new LdapAliasDereferencingException(
msg );
> -                //e.setResolvedName( aliasDn );
> -                throw e;
> -            }
> -
> -            String msg = I18n.err( I18n.ERR_224, aliasTarget, aliasDn );
> -            LdapAliasDereferencingException e = new LdapAliasDereferencingException(
msg );
> -            //e.setResolvedName( aliasDn );
> -            throw e;
> -        }
> -
> -        /*
>          * Check For Aliases External To Naming Context
>          *
>          * id may be null but the alias may be to a valid entry in
>
>
>

Mime
View raw message