directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Lecharny <>
Subject MessageId should not be injected into newly created Messages
Date Tue, 12 Apr 2011 12:27:48 GMT
Currently, we can inject a messageId in the Message constructors :

     public AbandonRequestImpl( final int id )

I don't think it's a good idea, as we usually generate those id 
automatically (it's an incremental number).

I suggest we don't inject the ID through the setMessageId( int ) if 
needed, as usually we don't need to do that.

Note that it's the same thing for all the requests.

thoughts ?

Emmanuel L├ęcharny

View raw message