Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Received-SPF: pass (nike.apache.org: domain of pajbam@gmail.com designates
 74.125.82.44 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=sender:from:mime-version:content-type:subject:date:in-reply-to:to
         :references:message-id:x-mailer;
        b=r8RVZUkVIcgsabh7EX84/b8bYICJvv5VR973s+oZ1uwivikEghxXd71x7b+qGFQjVt
         qFOOVch8W8TssLO6UF2exxnQO/sHozccK0vCqwNX3ZUk1cVdKSB7i6Mg2DhI5193RFlc
         TbsYH4HOFqlvfkTGfVYinoCNfWRMU5Imo0aL0=
Sender: Pierre-Arnaud Marcelot <pajbam@gmail.com>
From: Pierre-Arnaud Marcelot <pa@marcelot.net>
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: multipart/alternative; boundary=Apple-Mail-1-1063306771
Subject: Re: Some few classes that are probably stored at the right place...
Date: Wed, 30 Mar 2011 15:50:53 +0200
In-Reply-To: <AANLkTik0O+zvX80K_r5So8UntmgLFn15y8t8JWGjWffJ@mail.gmail.com>
To: "Apache Directory Developers List" <dev@directory.apache.org>
References: <4D9279DD.3000005@gmail.com>
 <CD595F64-14DF-416E-B896-448D016C12F9@marcelot.net>
 <AANLkTik0O+zvX80K_r5So8UntmgLFn15y8t8JWGjWffJ@mail.gmail.com>
Message-Id: <07B18C1B-CD2D-4B8B-BB64-030279AC251F@marcelot.net>


--Apple-Mail-1-1063306771
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

Hi Alex,

On 30 mars 2011, at 14:24, Alex Karasulu wrote:

>=20
>=20
> On Wed, Mar 30, 2011 at 12:20 PM, Pierre-Arnaud Marcelot =
<pa@marcelot.net> wrote:
> Hi Emmanuel,
>=20
> +1
>=20
> SearchScope could be in =
'org.apache.directory.shared.ldap.model.message'.
> LdapURL could in 'org.apache.directory.shared.ldap.model.url'.
>=20
> Shouldn't we also rename 'LdapURL' as 'LdapUrl' to match other class =
names (like Dn, Rdn, Oid, etc.)?
>=20
> Regards,
> Pierre-Arnaud
>=20
>=20
> My same thoughts. LdapUrl should go into message pkg too though - why =
have an extra package with just one or two classes?

Readability and longevity I guess.
We might need to add more classes related to LdapUrl later, like an URL =
factory or more.
Having this extra package ensures that we won't be tempted to move it =
afterwards, breaking compatibility in client applications.

At first, I was hesitating between either =
'org.apache.directory.shared.ldap.model' or =
'org.apache.directory.shared.ldap.model.url'.

Are you picking 'message' because LdapUrl is somehow related to =
referrals?
I've just verified and none of the classes under the 'message' package =
uses LdapUrl (not even 'Referral').
Other than that, I don't really see the link between the classes under =
this package and the LdapUrl class...

Regards,
Pierre-Arnaud

>=20
> Regards,
> Alex


--Apple-Mail-1-1063306771
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=us-ascii

<html><head></head><body style=3D"word-wrap: break-word; =
-webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hi =
Alex,<div><br><div><div>On 30 mars 2011, at 14:24, Alex Karasulu =
wrote:</div><br class=3D"Apple-interchange-newline"><blockquote =
type=3D"cite"><br><br><div class=3D"gmail_quote">On Wed, Mar 30, 2011 at =
12:20 PM, Pierre-Arnaud Marcelot <span dir=3D"ltr">&lt;<a =
href=3D"mailto:pa@marcelot.net">pa@marcelot.net</a>&gt;</span> =
wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin-top: 0px; =
margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; =
border-left-width: 1px; border-left-color: rgb(204, 204, 204); =
border-left-style: solid; padding-left: 1ex; position: static; z-index: =
auto; ">
Hi Emmanuel,<br>
<br>
+1<br>
<br>
SearchScope could be in =
'org.apache.directory.shared.ldap.model.message'.<br>
LdapURL could in 'org.apache.directory.shared.ldap.model.url'.<br>
<br>
Shouldn't we also rename 'LdapURL' as 'LdapUrl' to match other class =
names (like Dn, Rdn, Oid, etc.)?<br>
<br>
Regards,<br>
<font color=3D"#888888">Pierre-Arnaud<br>
</font><div><div></div><div =
class=3D"h5"><br></div></div></blockquote><div><br></div><div>My same =
thoughts. LdapUrl should go into message pkg too though - why have an =
extra package with just one or two =
classes?</div></div></blockquote><div><br></div><div>Readability and =
longevity I guess.</div><div>We might need to add more classes related =
to LdapUrl later, like an URL factory or more.</div><div>Having this =
extra package ensures that we won't be tempted to move it afterwards, =
breaking compatibility in client =
applications.</div><div><br></div><div>At first, I was hesitating =
between either 'org.apache.directory.shared.ldap.model' or =
'org.apache.directory.shared.ldap.model.url'.</div><div><br></div><div>Are=
 you picking 'message' because LdapUrl is somehow related to =
referrals?</div><div>I've just verified and none of the classes under =
the 'message' package uses LdapUrl (not even =
'Referral').</div><div>Other than that, I don't really see the link =
between the classes under this package and the LdapUrl =
class...</div><div><br></div><div>Regards,</div><div>Pierre-Arnaud</div><b=
r><blockquote type=3D"cite"><div class=3D"gmail_quote"><div>
<br></div><div>Regards,</div><div>Alex</div></div>
</blockquote></div><br></div></body></html>=

--Apple-Mail-1-1063306771--