directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Seelmann <seelm...@apache.org>
Subject Re: Some few classes to move out of model ?
Date Tue, 22 Mar 2011 22:15:38 GMT
On Tue, Mar 22, 2011 at 11:00 AM, Emmanuel Lecharny <elecharny@gmail.com> wrote:
> Hi guys,
>
> the ComplexDnParser, DnParser, FastDnParser, RdnParser  are classes
> currently present in model. I'm wondering if we should not move those
> classes out of model, or at least make them invisible ?

+1

> For instance, the DnPlaser class (well, it's not even a class, it's an enum,
> which sound very strange to me)

I just followed Joshua Bloch's "Effective Java(TM) Second Edition":
Item 3: Enforce the singleton property with (...) an enum type. But
now that the parsers are only used from the Dn/Rdn class that may not
make sense anymore.

Kind Regards,
Stefan

Mime
View raw message