directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Karasulu <akaras...@apache.org>
Subject Re: Why add @SuppressWarnings like this?
Date Fri, 11 Mar 2011 10:51:02 GMT
Just another point, these kinds of touch ups might be things we do in an RC
or GA since code refactorings and finishing touches may invalidate them. I
noticed while shifting around code and refactoring that these PMD
suppressions are lost or altered.

Regards,
Alex

On Fri, Mar 11, 2011 at 3:19 AM, Alex Karasulu <akarasulu@apache.org> wrote:

> Also is it possible to globally disable this so we don't have to add these
> suppressions to everywhere there is an OID string?
>
>     //This will suppress PMD.AvoidUsingHardCodedIP warnings in this class
>     @SuppressWarnings("PMD.AvoidUsingHardCodedIP")
>
>
> On Fri, Mar 11, 2011 at 1:44 AM, Alex Karasulu <akarasulu@apache.org>wrote:
>
>>     @SuppressWarnings("PMD.UnusedLocalVariable") // Remove me when the
>> TODO is fixed
>>
>> The TODO was to finish the implementation which will use the local
>> variable.
>>
>> Reason I ask, is because we should have PMD reports complain, after all it
>> is unfinished code that should stick out. Second the @SuppressWarning
>> identifier is not found and eclipse complains. Third there's already a TODO
>> there along with a JIRA issue for this particular case.
>>
>> Thoughts?
>>
>> Alex
>>
>
>

Mime
View raw message