directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pierre-Arnaud Marcelot ...@marcelot.net>
Subject Re: Pb with mvn eclipse:eclipse and -Dintegration
Date Wed, 30 Mar 2011 09:23:15 GMT
Did anyone had the chance to test that and confirm site generation is ok?

Thanks,
Pierre-Arnaud


On 18 mars 2011, at 15:53, Pierre-Arnaud Marcelot wrote:

> Funny thing...
> 
> I removed the 'integration' profile and regenerated the site again (with 'shared-integ'
projet added back as a module) and it worked this time.
> Sometimes Maven is really unpredictable...
> 
> I guess the issue was actually fixed by Stefan as he said in the previous discussion
thread and, for some reason, my machine kept complaining when I tested two weeks ago ( eventhough
I verified several times I was up-to-date)...
> 
> Could we all verify that site generation (mvn site) works for everyone with 'integration'
profile removed?
> If successful, I guess we could rollback the changes from two weeks ago.
> 
> Here's the diff to remove the integration profile:
>> Index: pom.xml
>> ===================================================================
>> --- pom.xml	(revision 1082861)
>> +++ pom.xml	(working copy)
>> @@ -83,6 +83,7 @@
>>     <module>all</module>
>>     <module>ldap</module>
>>     <module>dsml</module>
>> +    <module>integ</module>
>>     <module>distribution</module>
>>   </modules>
>> 
>> @@ -652,17 +653,6 @@
>> 
>>   <profiles>
>>     <profile>
>> -      <id>integration</id>
>> -      <activation>
>> -        <property>
>> -          <name>integration</name>
>> -        </property>
>> -      </activation>
>> -      <modules>
>> -        <module>integ</module>
>> -      </modules>
>> -    </profile>
>> -    <profile>
>>       <id>apache-release</id>
>>       <build>
>>         <plugins>
> 
> 
> 
> Regards,
> Pierre-Arnaud
> 
> On 18 mars 2011, at 15:27, Emmanuel Lecharny wrote:
> 
>> On 3/18/11 3:18 PM, Pierre-Arnaud Marcelot wrote:
>>> Hi Emmanuel,
>>> 
>>> On 18 mars 2011, at 15:02, Emmanuel Lecharny wrote:
>>> 
>>>> Hi guys,
>>>> 
>>>> I'm facing some painful problem with the last modifications made on the build
system : as the shared-integ is now depending on the -Dintegration profile to be present to
be executed, if you forget to provide this profile when doing a mvn eclipse:eclipse, the .classpath
is not generated correctly.
>>>> 
>>>> So now, to get all the module correctly imported in eclipse, you have to
do :
>>>> mvn eclipse:eclipse -Dintegration
>>>> 
>>>> Although I understand that it was mandatory to add this profile to get the
site generated and the release to be done, I think there are two problems with this approach
:
>>>> - first, no one has been informed about this modification
>>> This has been discussed in this thread on the ML [1]. You probably didn't see
it.
>> 
>> Yeah, my bad. I even remember that you asked me if I was able to run a mvn site.
I was working for a client the last two weeks, I most certainly didn't pay enough attention
to those mails.
>>>> - second, fixing an issue by creating a new one is not a solution.
>>> I don't think it created an issue, it's just something you need to know before
generating Eclipse files.
>>> Now, I understand it can become a problem when you're used to doing something
else for a long time, and having to specify to specify a specific profile can also be counter-intuitive.
>> It's an issue when you have to provide a profile which is useless when generating
the eclipse files : you are not splitting the project in two areas, one for normal proects,
and one for integration projects, when injecting all of them in eclipse. It should be done
in one pass with no argument.
>> 
>> Adding the -Dintegration to mvn eclipse:eclipse is just a workaround, and it's bad
smell.
>> 
>>>> I'm not blaming anyone here, I just think that when someone is facing such
an issue, creating a JIRA is necessary to get everyone informed about the problem, and giving
someone an opportunity to track the problem and eventually fix it.
>>> I think we can rollback on the specific profile creation and go back with old
system where everything was generated without the need to add a specific profile.
>>> We'd then have to try to find another fix for the site generation issue which
will block further releases.
>> 
>> yes, probably better. I know it's a pain in the ass, and I hate such problems, but
frankly, we do mvn eclipse:eclipse way more than site generation, and we have to get the frequent
operations working as simply as possible.
>> 
>> Ok, I created a JIRA so that we can track this problem down.
>> 
>> Thanks a lot guys !
>> 
>> -- 
>> Regards,
>> Cordialement,
>> Emmanuel L├ęcharny
>> www.iktek.com
>> 
> 


Mime
View raw message