Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Received-SPF: pass (nike.apache.org: domain of elecharny@gmail.com designates
 209.85.214.50 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:reply-to:user-agent:mime-version:to:subject
         :references:in-reply-to:content-type:content-transfer-encoding;
        b=Czpaiq0CsydTB4/GKU0W7xqh3fRErFu+JJGdI4qP2ARaeHT1n92VqqDIczh23VHlyr
         5etxlhEKmtqpjUYpejKNJLIs74fc1HeGUtL/vgd7RA8eBFYvlpeixmOnqyWfHnpArUl3
         E4LQ2bbrR/c8zBwty0muMY4wB9WLbjEz+/BAw=
Message-ID: <4D5B057B.8050404@gmail.com>
Date: Wed, 16 Feb 2011 00:00:11 +0100
From: Emmanuel Lecharny <elecharny@gmail.com>
Reply-To: elecharny@apache.org
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US;
 rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7
MIME-Version: 1.0
To: Apache Directory Developers List <dev@directory.apache.org>
Subject: Re: Some inconsistencies in the DN class
References: <4D57BF40.3060206@gmail.com>
	<AANLkTinn8b+RuLXd4yebrnduq+zM+tE24qP1soqdbJi_@mail.gmail.com>
	<4D594293.7010402@apache.org>
 <AANLkTi=RPmPU6YROinVfdUNY9=aotyQ47DeBypkD_-Hp@mail.gmail.com>
In-Reply-To: <AANLkTi=RPmPU6YROinVfdUNY9=aotyQ47DeBypkD_-Hp@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 2/15/11 11:12 PM, Stefan Seelmann wrote:
> (back to list, I think Emmanuel sent it by accident to me)
>
> On Mon, Feb 14, 2011 at 3:56 PM, Emmanuel Lécharny<elecharny@apache.org>  wrote:
>> Ok, after some cleanup, I come with two sets of restricted constructors :
>>
>> Empty Dn constructors :
>> - Dn()
>> - Dn( SchemaManager)
>>
>> Constructors having a DN (as a string) :
>> - Dn(String)
>> - Dn(SchemaManager, String)
>>
>> Constructors having RDNs (as strings) :
>> Dn(String...)
>> Dn(SchemaManager, String...)
> I don't understand what's the difference between those two groups if one codes
>    new Dn("abc")
> How does the runtime distinguish the two constructors. I have to read
> the spec again...

The Dn(String) uses a DN as a string, and the Dn(String...) is a bit 
more convoluted, as it almost anything which is a String, concatenate 
them to form a valid DN.
>> Cnstructors having a set of RDNs :
>> - Dn(Rdn)
>> - Dn(SchemaManager, Rdn)
> I guess you mean "Rdn..."
Yep.
>> The other constructors are most certainly spurious at this point :
>>
>>   Dn(Rdn child, Dn parent)
>>
>> can be replaced by :
>>
>>   parent.add( child );
>>
>> as the Dn is an immutable class.
>>
>> Is it ok for all of you ?
> I find it a bit inconvenient. If I see that a class has an "add()"
> method I expect that when using that method that the object is
> modified. I think I'd prefer to get rid of all the "add", "addAll" and
> "remove" methods that pretend mutability.

You are probably right. The problem is that if we want to remove the 
add() method, then we need to define a constructor like :

Dn dn = new Dn( "dc=example,dc=com" );
Dn newDn = new Dn( dn, "sn=test" );

Do we want that instead of :

Dn dn = new Dn( "dc=example,dc=com" );
Dn newDn = dn.add( "sn=test" );

?

-- 
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com