directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Lecharny <elecha...@apache.org>
Subject Re: Some inconsistencies in the DN class
Date Sun, 13 Feb 2011 13:55:21 GMT
Oops, sent to Alex only...

On Sun, Feb 13, 2011 at 2:54 PM, Emmanuel Lecharny <elecharny@apache.org>wrote:

> > For the exact same reason, I would remove the DN(String) constructor to
>> > favor the DN(String...) one.
>>
>> What does Dn(String...) with the array mean? On first sight I cannot
>> make sense of it. OK so you have an array of string arguments. What do
>> they represent?
>>
>
> String are RDNs :
>
> Dn dn = new Dn( "ou=example", "dc=com" );
>
>
>  > The Dn(String, String, byte[], List<Rdn>) constructor is only used
>> inside
>> > the server, and I don't think we really need it. I suggest to remove it.
>> >
>> > The package protected constructor Dn(String, String, byte[]) is also an
>> > issue. There is no reason to expose it to the end user.
>> >
>> > Last, not least, in order to have some symmetry between both classes of
>> > constructor, I'd like to suggest we create a schema aware constructor :
>> > Dn(SchemaManager, Rdn...)
>>
>> Is Rdn not schema aware already? Or is that just Dn?
>>
>
> Still have to check.
>
>
> --
> Regards,
> Cordialement,
> Emmanuel L├ęcharny
> www.iktek.com
>



-- 
Regards,
Cordialement,
Emmanuel L├ęcharny
www.iktek.com

Mime
View raw message