directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Karasulu (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DIRSHARED-102) Removed the hard wired versions from StandaloneLdapCodecService
Date Sat, 26 Feb 2011 04:00:29 GMT

    [ https://issues.apache.org/jira/browse/DIRSHARED-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999714#comment-12999714
] 

Alex Karasulu commented on DIRSHARED-102:
-----------------------------------------

I added code that:

   (1) dynamically constructs a set of packages by scanning the classpath for all bundles
and adding their exported packages to the set. 
   (2) This set is then merged with the Felix system property in case additional packages
are provided as system properties. 
   (3) Then as a last resort the hard coded values are used.

There is situation that I could not cover so I kept the 3rd item above. That's when the class
is run inside eclipse where the project running a test using the standalone codec depends
on another project instead of a bundled up jar.  In these cases the scanner for bundles on
the classpath does not obviously detect project relationships when inside eclipse. 

In these situations, API user projects setup in eclipse to run their test cases for new user
defined controls and extensions might encounter a problem. It can be solved by adding additional
packages to the felix system property. 

One work around for this is to take all eclipse project paths in the classpath and search
for a Manifest file in each on disk. But this will be tedious. Not a very clean solution.


For now I will close this issue since a workaround does exist for this one off problem that
may result in eclipse or other IDEs. 


> Removed the hard wired versions from StandaloneLdapCodecService
> ---------------------------------------------------------------
>
>                 Key: DIRSHARED-102
>                 URL: https://issues.apache.org/jira/browse/DIRSHARED-102
>             Project: Directory Shared
>          Issue Type: Task
>    Affects Versions: 1.0-M1
>            Reporter: Emmanuel Lecharny
>            Assignee: Alex Karasulu
>             Fix For: 1.0-M2
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> The StandaloneLdapCodecService class contains some hard wired version of used jars :
> ...
>     private static final String[] SYSTEM_PACKAGES =
>     {
>         "org.slf4j; version=1.6.0",
>         "org.apache.directory.shared.i18n; version=1.0.0",
>         "org.apache.directory.shared.util; version=1.0.0",
>         "org.apache.directory.shared.util.exception; version=1.0.0",
>         "org.apache.directory.shared.asn1; version=1.0.0",
>         "org.apache.directory.shared.asn1.util; version=1.0.0",
>         "org.apache.directory.shared.asn1.ber; version=1.0.0",
> ...
> This should be generated by the build system.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message