directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Lecharny <elecha...@gmail.com>
Subject Re: svn commit: r1060418 - in /directory/shared/trunk/ldap/src: main/java/org/apache/directory/shared/ldap/codec/controls/ main/java/org/apache/directory/shared/ldap/codec/controls/ppolicy/ main/java/org/apache/directory/shared/ldap/codec/controls/replicat...
Date Tue, 01 Feb 2011 13:56:08 GMT
On 2/1/11 2:48 PM, Felix Knecht wrote:
> On 02/01/2011 02:45 PM, Emmanuel Lecharny wrote:
>> On 2/1/11 8:49 AM, Felix Knecht wrote:
>>> @Emmanuel
>>> Probably overriding of the hashCode() method got lost during all the
>>> refactoring when overriding the equals() method.
>>> Can you add them as well? Your still having the code/logic in mind.
>>
>> I think I have added the missing hashcode() methods.
>>
>> It would be good to check that we have all the hashCode()/equals()
>> methods present in shared. I don't remember, bt I think one of the
>> report points out the missing ones.
>
> Yup. It's the PMD report 
> https://hudson.apache.org/hudson/view/A-F/view/Directory/job/dir-shared-site/site/pmd.html
>
>
>
Plus most of the classes pointed out by this report have been renamed or 
removed... What's wrong ?

-- 
Regards,
Cordialement,
Emmanuel L├ęcharny
www.iktek.com


Mime
View raw message