Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Received-SPF: pass (athena.apache.org: domain of akarasulu@gmail.com
 designates 209.85.216.50 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:date:x-google-sender-auth:message-id:subject
         :from:to:content-type;
        b=L2Q6wEmkXwW9usoZ6s0aRfIFZnA/OA9ZAGP3PCQur0p82QA/8cxLfiLiCv2o1uWHUa
         LWyiHeyS9VraoynwBw2u0xeudC191QIQuO3ZVM929b0GGl5JMuIRQds3uV+iXYTXfZMW
         /lu16WCbrSEw4d4Le62zdgbSM2uMwfQFdigAc=
MIME-Version: 1.0
Sender: akarasulu@gmail.com
Date: Tue, 25 Jan 2011 06:54:58 +0200
Message-ID: <AANLkTikEuriHmvdw9DB=w-dM-n=pUCZBC8J1wnRtTB7U@mail.gmail.com>
Subject: [Codec] Refactoring status
From: Alex Karasulu <akarasulu@apache.org>
To: Apache Directory Developers List <dev@directory.apache.org>
Content-Type: text/plain; charset=ISO-8859-1

Although I was going to apply the encoding decorator pattern last
(STEP 5 in previous status) I started discussing the approach with
Emmanuel last night and that kicked off the step ahead of the others.
And it's not so bad to do this first.

Now I have a few issues. First I am running out of time, need to crash
but could not fix two failing test cases:

Failed tests:
  testDecodeDelResponseSuccessWithControls(org.apache.directory.shared.ldap.codec.del.DelResponseTest)
  testDecodeDelResponseSuccess(org.apache.directory.shared.ldap.codec.del.DelResponseTest)

This regression appeared after creation and check in of the
LdapResultDecorator. Emmanuel if you could take a look at this for me
tomorrow morning this would be great.

Now the other bigger issue. There's no way I could finish the
SearchRequestImpl decoupling. I created the decoder and applied it. It
seems to be working just fine but the problem is SearchRequestImpl has
several codec dependencies. Seems there's a whole Filter subsystem for
the codec doing what the ExprNode does for LDAP filter creation in the
model. I'm hoping Emmanuel you can lend a hand here since you're most
familiar with this code.

If we can get this knocked out then I think we can bud ldap-model out
right after into it's own maven module as an OSGi bundle.

Thanks,
-- 
Alex Karasulu
My Blog :: http://www.jroller.com/akarasulu/
Apache Directory Server :: http://directory.apache.org
Apache MINA :: http://mina.apache.org
To set up a meeting with me: http://tungle.me/AlexKarasulu