Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 60572 invoked from network); 21 Jan 2011 07:50:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 21 Jan 2011 07:50:38 -0000 Received: (qmail 35621 invoked by uid 500); 21 Jan 2011 07:50:38 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 35425 invoked by uid 500); 21 Jan 2011 07:50:35 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 35417 invoked by uid 99); 21 Jan 2011 07:50:34 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Jan 2011 07:50:34 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of elecharny@gmail.com designates 74.125.82.44 as permitted sender) Received: from [74.125.82.44] (HELO mail-ww0-f44.google.com) (74.125.82.44) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Jan 2011 07:50:26 +0000 Received: by wwa36 with SMTP id 36so1577794wwa.1 for ; Thu, 20 Jan 2011 23:50:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:message-id:date:from:reply-to:user-agent :mime-version:to:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=qAN50nsw1HV/JV9fVdDzyd+yDde9yD/WHTyT9dSxKtw=; b=b/4vHfTxAfJJkglWd1BtEWwBGw5pq1c3ZDCvjkWifsVlsZ3+Gbs7xmIMHR5JZ0GfJm bF8cpW+N6issENch+nk3T+bkr8JSOBiKZj/kgQRS1OIkc1DKFWJgmYsGv1pLP1qVjFJb yjC8CEY2TBd7PwNIykaI5twzOTx1zvMwTGcJs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:reply-to:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; b=dZBfmj8sWtijgCDQ2YTzLPTrYy3Eq3apB1c2cRkaz4N0kXzxEJqnc10vgmGLiSrWCn U39mSC4piQuy1pa76ehM9Omsa281DrBBzaeSLNEt3O1UGKfXuPPvFzO9O6bLTCp3TjAY sz1ot6blMEkRTW+63dkPeoAfwjoSrhzxvdoTk= Received: by 10.216.167.13 with SMTP id h13mr238596wel.95.1295596206050; Thu, 20 Jan 2011 23:50:06 -0800 (PST) Received: from emmanuel-lecharnys-MacBook-Pro.local ([78.251.125.189]) by mx.google.com with ESMTPS id i80sm4724605wej.4.2011.01.20.23.50.01 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 20 Jan 2011 23:50:04 -0800 (PST) Message-ID: <4D393AAA.3020609@gmail.com> Date: Fri, 21 Jan 2011 08:50:02 +0100 From: Emmanuel Lecharny Reply-To: elecharny@apache.org User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7 MIME-Version: 1.0 To: Apache Directory Developers List Subject: Re: [ASN.1] Thoughts about ASN.1 code References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org On 1/21/11 7:56 AM, Alex Karasulu wrote: > Quick brain dump as I was refactoring yesterday. > > ASN1 API => shared-asn1-api > o some stuff old and useless, needs cleanup: i.e. > stateful/stateless codec remnants Yes. It has to be removed. The client-API does not use anymore those layers. > o some per class, per interface review and cleanup needed That can be done. > o is it worth making some parts swappable? don't think so but might > be worth a check I think we won't rewrite a forth ASN.1 codec. Also it's possible to do so without having to define a swaping layer, as the codec is added as a MINA filter, thus defining a new codec is easy : simply define a new filter. > ASN1 BER => shared-asn1-ber > o again has some old remnant code that needs cleanup > o some interfaces are here that can be exposed as SPI > o some stuff seems reusable regarding of encoding used like Value etc > o need to check dependencies, how much are we exposing and using > from outside how much can we actually hide here > o BER/DER/CER flag for changing mode of operation? to be checked. I'm available this afternoon if yu want to disuss those cleanups. -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com