From dev-return-36641-apmail-directory-dev-archive=directory.apache.org@directory.apache.org Tue Jan 18 09:06:13 2011 Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 69390 invoked from network); 18 Jan 2011 09:06:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 18 Jan 2011 09:06:13 -0000 Received: (qmail 96559 invoked by uid 500); 18 Jan 2011 09:06:13 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 96350 invoked by uid 500); 18 Jan 2011 09:06:10 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 96336 invoked by uid 99); 18 Jan 2011 09:06:09 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Jan 2011 09:06:09 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of akarasulu@gmail.com designates 209.85.216.50 as permitted sender) Received: from [209.85.216.50] (HELO mail-qw0-f50.google.com) (209.85.216.50) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Jan 2011 09:06:04 +0000 Received: by qwd6 with SMTP id 6so5845999qwd.37 for ; Tue, 18 Jan 2011 01:05:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; bh=VtkVKxtxsyYA4VK5ZBm8pVS5sexdP243+6OBdyxtp9Y=; b=tuQpwsNNRAmUZKaFatf/GjhfBLMIX3SQw7rpVik6yRNelCfUR/itP+moKKxMeK445n BwQzircwlCl4av9kMTxl3rVGH69M9I32Y/AF9zyxJ2rCMtjcL0wtNLAL1Whk4hdf6lf2 zgKRIoxdMfCG885HQ1xb6KGETilpR3canyH6o= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; b=xIC6k0a8etvotGnxbHsufluRyDcEhFzMyNWoJH0rW7cnGRlj8EZBzylNw7zU+J5EMy h7T+dHjZoM7m63Uj5AslL+8gT2/y0FGFHi476NzV0Y24RzSGY26utG3xX2UXEXxLhcVr yVQlT7dNs8LUdlikSiL+rdKLleT2YHY5NdMfE= MIME-Version: 1.0 Received: by 10.229.229.18 with SMTP id jg18mr4506624qcb.276.1295341543498; Tue, 18 Jan 2011 01:05:43 -0800 (PST) Sender: akarasulu@gmail.com Received: by 10.229.63.23 with HTTP; Tue, 18 Jan 2011 01:05:43 -0800 (PST) In-Reply-To: <5CD6EF6E-FCF1-4457-A313-5A6F3645ADD5@marcelot.net> References: <5CD6EF6E-FCF1-4457-A313-5A6F3645ADD5@marcelot.net> Date: Tue, 18 Jan 2011 11:05:43 +0200 X-Google-Sender-Auth: vOzcI1g2TKHUyyvXhv0MGuBdxzY Message-ID: Subject: Re: [OSGi] Shared bundles update From: Alex Karasulu To: Apache Directory Developers List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi Pierre, On Mon, Jan 17, 2011 at 3:39 PM, Pierre-Arnaud Marcelot w= rote: > Hi Alex, > Thanks for converting the modules into bundles. No biggy just some maven xml. > I took some extra steps [1] [2] (the same ones as for the i18n modules) t= o > make the bundle fully compatible with Studio's build: > - Generation of the MANIFEST.MF file in a top level META-INF folder (igno= red > by SVN) > - Usage of ${project.property} instead of ${pom.property} for Maven 3 > compliance Ahh yes I should make the other bundles do the same. We have to do this for all modules in ads and shared. > - Removal of Bundle-Version directive which is inherited automatically fr= om > the project version Oh I did not know we have to do this. Can you explain why we have to do this just so I can understand? > - Usage of ${project.name} as Bundle-Name (instead of ${project.artifactI= d}) Sure we can do this too. > After fixing an issue with a wrong version used in Studio for Commons Lan= g > (2.3 instead of 2.5) I was able to replace Studio's libraries plugins of > Shared by the OSGI-fied Shared dependencies within Eclipse. > Studio seems to work like a charm. :) > I think we should also turn the 'all' module as a bundle. It's pretty eas= y > and doesn't harm to do it. Yeap no problem we can do this as well. We just need to make sure we use the same tactic as I did in shared-ldap-schema because of the bug in the maven-bundle-plugin. > Regards, > Pierre-Arnaud > [1] -=A0http://svn.apache.org/viewvc?rev=3D1059824&view=3Drev > [2] -=A0http://svn.apache.org/viewvc?rev=3D1059834&view=3Drev > > On 16 janv. 2011, at 14:36, Alex Karasulu wrote: > > The conversion of ldap-schema into a bundle is complete but I want to > test it in the OSGi environment to make sure it's working properly. > Might setup an integration test using felix in the shared-integ module > and make sure the module only runs with an -Dintegration flag/profile. > > Is it worth turning the 'all' module, shared-all, into a bundle as > well? Thoughts? > > Regards, > Alex > > On Sun, Jan 16, 2011 at 1:53 PM, Alex Karasulu wro= te: > > STATUS: > > ------------ > > The following modules have been converted into bundles: > > =A0 =A0o i18n > > =A0 =A0o ldap > > =A0 =A0o ldap-client-api > > =A0 =A0o dsml-parser > > =A0 =A0o dsml-engine > > I will not bother with the following modules for reasons that should > > seem apparent: > > =A0 =A0o all > > =A0 =A0o integ > > The following modules still need to be made into bundles: > > =A0 =A0o ldap-schema > > > ISSUES: > > ----------- > > There seems to be some issues with the default operation of the > > maven-bundle-plugin where the schema file names are causing the plugin > > to barf. Here's something I had posted a couple years ago about the > > matter on felix-dev which seems still to be the case [0]. > > Note the ldap-schema packages together schema LDIF files into the Jar. > > This is extracted out by a LdifExtractor class. The maven antrun > > plugin is used to build index files as well and the default jar > > archiver is used. > > This however probably can be solved by just generating the OSGi > > manifest with the bundle plugin and letting the current process using > > the jar archiver run without overwriting the manifest file. > > I'll play around with this. > > > GOING FORWARD: > > -------------------------- > > I guess we can start using the converted bundles in the studio build > > as direct dependencies. Also Pierre/Stefan could y'all update me on > > the steps we needed in the studio build to use the direct bundle > > dependency? That way I can update studio's build myself to use the > > ldap-schema bundle once it is complete. I also want to understand what > > steps are needed to change studio's build when we break out new > > bundles from inside shared-ldap. > > -- > > [0] -- http://goo.gl/5WT5i > > > Thanks, > > -- > > Alex Karasulu > > My Blog :: http://www.jroller.com/akarasulu/ > > Apache Directory Server :: http://directory.apache.org > > Apache MINA :: http://mina.apache.org > > To set up a meeting with me: http://tungle.me/AlexKarasulu > > > --=20 Alex Karasulu My Blog :: http://www.jroller.com/akarasulu/ Apache Directory Server :: http://directory.apache.org Apache MINA :: http://mina.apache.org To set up a meeting with me: http://tungle.me/AlexKarasulu