directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Karasulu <akaras...@apache.org>
Subject Re: svn commit: r1063987 - in /directory: apacheds/trunk/core-api/src/main/java/org/apache/directory/server/core/interceptor/context/ apacheds/trunk/core-jndi/src/main/java/org/apache/directory/server/core/jndi/ apacheds/trunk/core/src/main/java/org/
Date Sun, 30 Jan 2011 20:29:59 GMT
On Sun, Jan 30, 2011 at 6:04 PM, Alex Karasulu <akarasulu@apache.org> wrote:

>
>
> On Sun, Jan 30, 2011 at 12:13 AM, Stefan Seelmann <seelmann@apache.org>wrote:
>
>>
>> It doesn't make sense - and it's also dangerous - to have a static
>> instance of a control. It is possible to alter the criticality of a
>> control which may cause issues when using the singleton in a
>> multi-threaded environment.
>>
>>
> Yes this is not good. I forgot about being able to vary the criticality of
> even the standard controls. I will revert this. Thanks for the heads up.
>

OK I fixed this. Thanks for spotting it.

This is kind of telling me it's always good to go slow and steady so all
eyes have a chance to see the problems.

-- 
Alex Karasulu
My Blog :: http://www.jroller.com/akarasulu/
Apache Directory Server :: http://directory.apache.org
Apache MINA :: http://mina.apache.org
To set up a meeting with me: http://tungle.me/AlexKarasulu

Mime
View raw message