directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pierre-Arnaud Marcelot ...@marcelot.net>
Subject Re: svn commit: r1061048 - in /directory/studio/trunk/libraries: ./ pom.xml
Date Thu, 20 Jan 2011 09:02:23 GMT
Hi Alex,



On 20 janv. 2011, at 00:06, Alex Karasulu wrote:

> Pierre,
> 
> Not really feeling good about this change even though it did not break
> the studio build. Could you review this for me?

Sure, but I'm confident. There should be no issue.

As long as you already have shared artifacts in your M2 repo it should work properly.

> Perhaps there something that needs to be done to make sure the bundle
> deps in shared show up as IDE project dependencies instead of deps to
> the artifacts in the repository.

Studio is not explicitly depending a shared jars but instead requires them as bundles in its
MANIFEST.MF files.
So, Eclipse will (should) link the projects properly too.

At least, that's what I noticed so far. 

> Thanks,
> Alex
> 
> On Thu, Jan 20, 2011 at 12:56 AM,  <akarasulu@apache.org> wrote:
>> Author: akarasulu
>> Date: Wed Jan 19 22:56:49 2011
>> New Revision: 1061048
>> 
>> URL: http://svn.apache.org/viewvc?rev=1061048&view=rev
>> Log:
>> OK - I'm trying to get the build working in
>> 
>>   https://svn.apache.org/repos/asf/trunks
>> 
>> But to do so I had to remove this externals link. I checked and it's not causing
>> build breakage but I'm not very confident about the side effects. Please review
>> this for me Pierre.
>> 
>> Thanks!
>> 
>> Modified:
>>    directory/studio/trunk/libraries/   (props changed)
>>    directory/studio/trunk/libraries/pom.xml
>> 
>> Propchange: directory/studio/trunk/libraries/
>> ------------------------------------------------------------------------------
>> --- svn:externals (original)
>> +++ svn:externals Wed Jan 19 22:56:49 2011
>> @@ -1 +1 @@
>> -shared https://svn.apache.org/repos/asf/directory/shared/trunk/
>> +
>> 
>> Modified: directory/studio/trunk/libraries/pom.xml
>> URL: http://svn.apache.org/viewvc/directory/studio/trunk/libraries/pom.xml?rev=1061048&r1=1061047&r2=1061048&view=diff
>> ==============================================================================
>> --- directory/studio/trunk/libraries/pom.xml (original)
>> +++ directory/studio/trunk/libraries/pom.xml Wed Jan 19 22:56:49 2011
>> @@ -56,7 +56,6 @@
>>     <module>org.slf4j.api</module>
>>     <module>org.slf4j.log4j12</module>
>>     <module>org.xpp3.xpp3</module>
>> -    <module>shared</module>
>>   </modules>
>> 
>>   <build>
>> 
>> 
>> 
> 
> 
> 
> -- 
> Alex Karasulu
> My Blog :: http://www.jroller.com/akarasulu/
> Apache Directory Server :: http://directory.apache.org
> Apache MINA :: http://mina.apache.org
> To set up a meeting with me: http://tungle.me/AlexKarasulu


Mime
View raw message