On Mon, Dec 13, 2010 at 5:39 PM, Stefan Seelmann <seelmann@apache.org> wrote:
Hi dev,

our current partition implementations use different fields/methods to
configure the location where partition data is persisted:
- BTreePartition defines a 'partitionDir' with getter/setter, this is
used by the JdbmPartition
- AbstractLdifPartition defines a 'workingDirectory' with
getter/setter, this is used by LdifPartition
- SingleFileLdifPartition defines a 'ldifFile' which is set by the constructor

I'd like to propose to remove the existing fields and to add a new
'partitionLocation' (or partitionPath? better names welcomed) field
including getter/setter instead:
- for JdbmPartition and LdifPartition this points to a directory in file system
- for SingleFileLdifPartition this points to the single LDIF file in file system

Thoughts?

+1

I thought about making the partitionPath a URL but just saw your email. Consistency is good but why is using a URL so complex?

Regards,
--
Alex Karasulu
My Blog :: http://www.jroller.com/akarasulu/
Apache Directory Server :: http://directory.apache.org
Apache MINA :: http://mina.apache.org
To set up a meeting with me: http://tungle.me/AlexKarasulu