directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Lecharny <elecha...@apache.org>
Subject Re: Disable Kerberos modules and tests (was: Build failed in Hudson: dir-studio-jdk15-ubuntu-deploy #97)
Date Sun, 21 Nov 2010 19:56:58 GMT
Felix,

I had time to review the way we process the flags, and it nedds some love.
I'll try to get closer to a solution tonite.

This is what happens when no one maitain some code for years, and suddenly
you need to fix it... This is also why we don't like code dump at Apache :)

On Sun, Nov 21, 2010 at 7:28 PM, Felix Knecht <felixk@apache.org> wrote:

> I think that you are close to the problem with this KerberosFlags not
>> being handled correctly,felix.
>>
>> The way we manipulate them is not consistent with the new storage, as
>> the check is lookig for bits expecting them to be stored from right to
>> left in the integer, when they are now stored from left to right.
>>
>> I have to go and see my parents this afternoon, so I won't probably be
>> able to fix it, or maybe while commuting (I have roughly 45 minutes of
>> train), so if you come with a solution before me, that'll be fine. But
>> if you do something else this afternoon (this is sunday, for X sake !),
>> maybe I'll come with a fix on my own.
>>
>
> You're very welcome :-)
>
>
>  In any case, I think we can get this bummer fixed tonite !
>>
>
> I added @Ignore to failing test ATM for folowing classes:
> -
> protocol-kerberos/src/test/java/org/apache/directory/server/kerberos/protocol/TicketGrantingPolicyTest.java
> -
> protocol-kerberos/src/test/java/org/apache/directory/server/kerberos/protocol/TicketGrantingServiceTest.java
>
> Somehow I'm getting the impression the more I try to fix the more new
> problems arise ...
>



-- 
Regards,
Cordialement,
Emmanuel L├ęcharny
www.iktek.com

Mime
View raw message