Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Received-SPF: neutral (nike.apache.org: local policy)
Message-ID: <4C8531BE.1010906@apache.org>
Date: Mon, 06 Sep 2010 20:23:58 +0200
From: Felix Knecht <felixk@apache.org>
Reply-To: felixk@apache.org
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
 rv:1.9.2.8) Gecko/20100830 Lightning/1.0b2pre Thunderbird/3.1.2
MIME-Version: 1.0
To: Apache Directory Developers List <dev@directory.apache.org>
Subject: Re: Shared file review
References: <4C849B64.20007@gmail.com>
In-Reply-To: <4C849B64.20007@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/06/10 09:42, Emmanuel Lecharny wrote:
>  Hi guys,
> 
> as I was just back from hollidays, and as my brain was fried, I started
> with a simple task this week-end : reviewing shared files. I have
> created a file I put in shared (file-review.txt) which track the review
> progress.
> 
> I'm checking many aspects :
> - ASF header is present
> - Class header is present and correct (javadoc, @author, @pram for
> generic classes)
> - Fields Javadoc
> - Methods Javadoc
> - No more TODO (TODOs must be transformed to JIRAs)
> - No more error message without i18n, explicit error code (ie, not
> ERR_02008 for instance)
> - No more warnings
> - Formater applied
> - Checkstyle and findbugs cleared
> 
> About Checkstyle and Findbugs, I have cleared a lot of items, some of
> them will remain, so may be we can tune the config to get rid of them :
> 'xxx' hide a field (this is because we use the same name in the set(
> param ) methods than the associated field.
> 
> Felix, may be you can tune that ?

NP I'll do for the files in file-review.txt.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkyFMb4ACgkQ2lZVCB08qHEEpQCfWEoB17x+DXH30bdQzFmhNYLz
Z2gAoN8I0Jv1b0XAwP/od7t/ijEKQyTd
=dDZu
-----END PGP SIGNATURE-----