Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Received-SPF: pass (athena.apache.org: domain of elecharny@gmail.com
 designates 74.125.82.42 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:reply-to:user-agent:mime-version:to:subject
         :content-type:content-transfer-encoding;
        b=GfNar5fqLkEq2caR5e0pxedTgj1Ef7xtG9rI3OhBj8Y0rw/TC/Vbq7N/gB8Embj3kX
         aM7OXjIGtT5SYn3LpWQIt0/A7+MZvmjpvpg53vinOmgqXyEJMrX/fczSYvz2C6doTFYz
         jUi4rC1SFMB2O7UkunClgmrYqrVEEKtV9Y9y8=
Message-ID: <4C849B64.20007@gmail.com>
Date: Mon, 06 Sep 2010 09:42:29 +0200
From: Emmanuel Lecharny <elecharny@gmail.com>
Reply-To: elecharny@apache.org
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US;
 rv:1.9.2.8) Gecko/20100802 Thunderbird/3.1.2
MIME-Version: 1.0
To: Apache Directory Developers List <dev@directory.apache.org>
Subject: Shared file review
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

  Hi guys,

as I was just back from hollidays, and as my brain was fried, I started 
with a simple task this week-end : reviewing shared files. I have 
created a file I put in shared (file-review.txt) which track the review 
progress.

I'm checking many aspects :
- ASF header is present
- Class header is present and correct (javadoc, @author, @pram for 
generic classes)
- Fields Javadoc
- Methods Javadoc
- No more TODO (TODOs must be transformed to JIRAs)
- No more error message without i18n, explicit error code (ie, not 
ERR_02008 for instance)
- No more warnings
- Formater applied
- Checkstyle and findbugs cleared

About Checkstyle and Findbugs, I have cleared a lot of items, some of 
them will remain, so may be we can tune the config to get rid of them :
'xxx' hide a field (this is because we use the same name in the set( 
param ) methods than the associated field.

Felix, may be you can tune that ?

Ok, now, it's monday, and I've to run back to the office... grrr...

-- 
Regards,
Cordialement,
Emmanuel L�charny
www.iktek.com