directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Felix Knecht <fel...@apache.org>
Subject Re: Shared file review
Date Tue, 07 Sep 2010 16:33:09 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/07/10 09:02, Emmanuel Lecharny wrote:
>  On 9/7/10 6:53 AM, Felix Knecht wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>>
>>>> About Checkstyle and Findbugs, I have cleared a lot of items, some of
>>>> them will remain, so may be we can tune the config to get rid of them :
>>>> 'xxx' hide a field (this is because we use the same name in the set(
>>>> param ) methods than the associated field.
>> I tuned the checkstyle configuration [1] and redeployed the reports. For
>> findbugs I haven't found issues about hidden fields, but maybe I just
>> overlooked them.
> It's on checkstyle, not findbugs.
> 
> What is strange is that the warning is still present ...

Of course I could rid of all the 'xxx' hides a field stuff, but I'm not
sure if this is really wanted. If there are some rare special cases
maybe they can be marked as false positives directly either by
annotation or by configuration. But using general configurations (like
"constructor parameters" e.g.) should be the default way to go IMO.

> 
> However, I see that teh file I revewied are way better now :)
> 
> Thanks Felix !
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkyGaUUACgkQ2lZVCB08qHFIewCcCgu9g5N9dFmCXmTn6X53wPDH
ckcAnA7EmTtuL0YGWq7DBZOQuMj5GHUm
=OMA+
-----END PGP SIGNATURE-----

Mime
View raw message