directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Lecharny (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DIRSERVER-1541) Numerous JUnit tests failing on Windows.
Date Mon, 13 Sep 2010 07:29:35 GMT

    [ https://issues.apache.org/jira/browse/DIRSERVER-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908654#action_12908654
] 

Emmanuel Lecharny commented on DIRSERVER-1541:
----------------------------------------------

I have a concern about this modification in the latest patch :

-    // The regexp pattern matcher
-    private Pattern datePattern = Pattern.compile( GENERALIZED_TIME_PATTERN ); 
+    // The regexp pattern is immutable, only one instance needed.
+    private static final Pattern DATE_PATTERN = Pattern.compile( GENERALIZED_TIME_PATTERN
); 
 
     /**
      * Creates a new instance of GeneralizedTimeSyntaxChecker.
@@ -134,7 +134,7 @@
         }
         
         // Start the date parsing
-        boolean result = datePattern.matcher( strValue ).find();
+        boolean result = DATE_PATTERN.matcher( strValue ).find();


I'm not sure that DATE_PATTERN.matcher is thread-safe. Can this be checked ? 

(the problem is not the Pattern itself, but the fact that it returns a Matcher which is not
thread safe when calling the matcher() method on the Pattern).

> Numerous JUnit tests failing on Windows.
> ----------------------------------------
>
>                 Key: DIRSERVER-1541
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1541
>             Project: Directory ApacheDS
>          Issue Type: Bug
>          Components: core, ldap, schema
>    Affects Versions: 2.0.0-RC1
>         Environment: All Microsoft Windows.
>            Reporter: Richard M Feezel
>            Assignee: Emmanuel Lecharny
>            Priority: Minor
>             Fix For: 2.0.0-RC1
>
>         Attachments: ADS_Patches.diff.txt, WindowsPatches.diff
>
>
> File names and paths are not being handled in a platform-independent manner is all cases.
> In particular, in regex matching patterns the "\" has special meaning.  On Windows the
"\" is used as the file directory separator character so a regex attempting to test for a
directory separator character must be constructed in a platform-dependent manner.
> Also, certain characters are not allowed in file names in Microsoft Windows.  Any attempt
to use such names must have these special characters "escaped" to safe characters.  Since
the "\" character is the directory separator character it is unsuitable for special character
escaping.
> Finally, in the JdbmStoreTest test, stores and indexes must be destroyed and/or closed
to permit deletion of the underlying files at completion of the test run.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message