directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pierre-Arnaud Marcelot>
Subject Re: Message merging : done !
Date Wed, 18 Aug 2010 08:34:38 GMT
Congrats Emmanuel.

What a work...

I hope the refactoring of the dsml-parser won't be too hard as old messages classes are used
all over the place. Tell me if I can help you. ;)


On 18 août 2010, at 09:19, Kiran Ayyagari wrote:

> On Wed, Aug 18, 2010 at 6:39 AM, Emmanuel Lecharny <> wrote:
>>  Hi guys,
>> so it's done, all the messages from API, codec and internal have been merged
>> in one single set of classes ! pfewww... It ends up with many lines of
>> useless code removed from trunk, probably a few thousands.
>> There are some remaining tasks to be completed though before we can merge
>> back to trunk the branch :
>> - The ImportCommand is still broken (all have been commented inside it), and
>> the best would be to rewrite it using the API instead of plain channels.
>> - There is some issues with the StoredProcedure (tests have been @Ignored
>> atm), as we are using JNDI context to process them in the server. We need
>> some conversion from and to JNDI extendedRequest/Response to be written in
>> JNDIUtils
>> - At this point, there is some duplication of code as JndiUtils is defined
>> in shared-jndi, so we can't use JndiUtils from there. We should inject the
>> classes from shared-jndi into shared-ldap
>> - Last, not least, the dsml-parser is still using the Codec classes. I have
>> to review this code.
>> We are close, very close !
> whoa, this is great :)
>> --
>> Regards,
>> Cordialement,
>> Emmanuel Lécharny
> Kiran Ayyagari

View raw message