directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pierre-Arnaud Marcelot ...@marcelot.net>
Subject Re: [Studio-Plugin] Is there a way to propagate the list of profiles to the forked mvn eclipse:eclipse goal
Date Fri, 13 Aug 2010 16:40:49 GMT
I just committed the fix.

I was about to create a JIRA for this but I figured out that the Studio Maven Plugin doesn't
have its own JIRA Project space.

Should we consider creating one for it ?

Regards,
Pierre-Arnaud

On 13 août 2010, at 18:30, Pierre-Arnaud Marcelot wrote:

> On 13 août 2010, at 18:21, Felix Knecht wrote:
> 
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>> 
>> Hey, the studio-plugin is *our* plugin not mine ;-) (and I won't call me
>> a maven guru BTW ...).
> 
> Of course, Felix. But you're far more skilled than I am.
> But I try to improve myself... ;)
> 
> 
>> So just go ahed and commit it!
> 
> Sure!
> 
> Thanks,
> Pierre-Arnaud
> 
>> Regards
>> Felix
>> 
>> PS:
>> Thanks Jeff for very quick response
>> 
>> 
>>> If that's ok with everyone, I'd like to commit it to the current trunk (and 
>>> create and resolve an associated issue in JIRA).
>>> WDYT ?
>>> 
>>> Regards,
>>> Pierre-Arnaud
>>> 
>>> 
>>> 
>>> 
>>> On 13 août 2010, at 17:20, Pierre-Arnaud Marcelot wrote:
>>> 
>>>> Hi Jeff,
>>>> 
>>>> I see that we do have access to a project instance in our goal Mojo:
>>>> protected MavenProject project;
>>>> 
>>>> I'm going to try this.
>>>> 
>>>> Thanks a lot.
>>>> 
>>>> Regards,
>>>> Pierre-Arnaud
>>>> 
>>>> 
>>>> On 13 août 2010, at 17:09, Jeff MAURY wrote:
>>>> 
>>>>> If you use the MavenProject object, you have a method called 
>>>>> getActiveProfiles: see 
>>>>> http://www.docjar.com/docs/api/org/apache/maven/project/MavenProject.html#getActiveProfiles
>>>>> 
>>>>> Regards
>>>>> Jeff
>>>>> 
>>>>> On Fri, Aug 13, 2010 at 4:57 PM, Pierre-Arnaud Marcelot <pa@marcelot.net

>>>>> <mailto:pa@marcelot.net>> wrote:
>>>>> 
>>>>>   Hi dev (and especially Felix - our Maven plugin guru),
>>>>> 
>>>>>   We have recently introduced the 'studio-full' profile in Studio's build.
>>>>>   This profile allows us to maintain the "daily" build (mvn clean install)
>>>>>   very fast by only including the modules which really matter the most
to
>>>>>   us (like the core and ui plugins) and excluding from build modules
like
>>>>>   help, feature plugins or update site generation (which don't change
very
>>>>>   often).
>>>>> 
>>>>>   All those excluded modules are part of the 'studio-full' profile.
>>>>> 
>>>>>   Now, I noticed that we're facing a problem when we want to generate
the
>>>>>   Eclipse descriptors of the excluded modules using 'mvn studio:eclipse
>>>>>   -Pstudio-full'.
>>>>> 
>>>>>   I've looked at the code of the Studio Plugin and found out that we're
>>>>>   forking a Maven goal (mvn eclipse:eclipse). The problem is that the
>>>>>   '-Pstudio-full' is not appended to that execution and then, the
>>>>>   eclipse:eclipse goal is not run on the excluded modules.
>>>>> 
>>>>>   I tried to modify the Studio Plugin in order to be able to propagate
the
>>>>>   list of profiles to the fork Maven goal but I couldn't found a way
to get
>>>>>   the list of currently used profiles.
>>>>> 
>>>>>   If someone has an idea...
>>>>> 
>>>>>   Thanks,
>>>>>   Pierre-Arnaud
>>>>> 
>>>>> 
>>>>> 
>>>>> 
>>>>> -- 
>>>>> "Legacy code" often differs from its suggested alternative by actually

>>>>> working and scaling.
>>>>> - Bjarne Stroustrup
>>>>> 
>>>>> http://www.jeffmaury.com <http://www.jeffmaury.com/>
>>>>> http://riadiscuss.jeffmaury.com <http://riadiscuss.jeffmaury.com/>
>>>>> http://www.twitter.com/jeffmaury
>>>> 
>>> 
>> 
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v2.0.16 (GNU/Linux)
>> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>> 
>> iEYEARECAAYFAkxlcRAACgkQ2lZVCB08qHFDJgCgvw6RpI/qW2kWtf3SmUODkM8N
>> AiYAoLPPZoNptWZyqX/OfdF27SBLIS1x
>> =LV3M
>> -----END PGP SIGNATURE-----
> 


Mime
View raw message