From dev-return-34424-apmail-directory-dev-archive=directory.apache.org@directory.apache.org Fri Jul 02 08:36:30 2010 Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 68973 invoked from network); 2 Jul 2010 08:36:29 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 2 Jul 2010 08:36:29 -0000 Received: (qmail 66958 invoked by uid 500); 2 Jul 2010 08:36:29 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 66757 invoked by uid 500); 2 Jul 2010 08:36:26 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 66739 invoked by uid 99); 2 Jul 2010 08:36:25 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Jul 2010 08:36:25 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of elecharny@gmail.com designates 74.125.82.44 as permitted sender) Received: from [74.125.82.44] (HELO mail-ww0-f44.google.com) (74.125.82.44) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Jul 2010 08:36:17 +0000 Received: by wwb24 with SMTP id 24so325453wwb.1 for ; Fri, 02 Jul 2010 01:34:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:reply-to :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=t5PA2Y0MxwndFhT6ooF20PnIAlCKs1O1qUuwEgnaCnk=; b=utlUMg2iX0Jevrfc70bl4YBW7OSRHLrpYkBIHINqemFriEhfuNI7nTakOTloroxl+J aLtceokrFp8fBdtxL4Z9wYC1EARnA7QQUOXExWOhb0lHfCkD1gMqjK2Isp2VlG5mNYWj 59opHTkti0IzqQ23tZttUYNFq4oKZCzYMyd0s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:reply-to:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; b=FznL1RBPbaxA9D1RkICzbV0odrU4f3UWqAH+FO2YAwpD02UYLEkvR0brJw5497ao/o +akdHeeEa18iTozZb0+uC7bn7BC3ZUYs6IoW0aU7xNaTUK+gR3JY+OpEKPFZcvc9KKJv p/3NLSVcFUnZARXiNSuowQ4ZHR3EwGDvPwNXs= Received: by 10.227.129.82 with SMTP id n18mr225744wbs.111.1278059697088; Fri, 02 Jul 2010 01:34:57 -0700 (PDT) Received: from emmanuel-lecharnys-MacBook-Pro.local ([78.192.106.184]) by mx.google.com with ESMTPS id g37sm2893819wbg.21.2010.07.02.01.34.55 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 02 Jul 2010 01:34:56 -0700 (PDT) Message-ID: <4C2DA510.3060000@gmail.com> Date: Fri, 02 Jul 2010 10:36:32 +0200 From: Emmanuel Lecharny Reply-To: elecharny@apache.org User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.4) Gecko/20100608 Thunderbird/3.1 MIME-Version: 1.0 To: Apache Directory Developers List Subject: Re: ACITuple refactoring References: <4C2D986F.3040802@gmail.com> <0CC2065C-9C85-426F-AFAD-343EB99C6D75@gmail.com> In-Reply-To: <0CC2065C-9C85-426F-AFAD-343EB99C6D75@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org On 7/2/10 10:09 AM, Alex Karasulu wrote: > Sounds good to me. This is pretty nasty code. The cleanup is much needed. Some correction to my previous mail : - The checkPermission() method is different from the hasPermission(), as one is throwing an exception, and is used in the interceptor before going down the chain, the other one is used for the search operation only, when the candidate entries are evaluated. We should keep those two methods. -- Regards, Cordialement, Emmanuel Lécharny www.nextury.com