Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Received-SPF: pass (nike.apache.org: domain of akarasulu@gmail.com designates
 209.85.161.50 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:content-type;
        b=Ccs9w0O4z52Fb4qr0gQfGB57Qm6pzpbbfP8J4r7EvZZ0BHqjDGHsT51RrzX4bQQErQ
         Ya6ATB41Mjq6q/1w/6MZNMODbKBRWoHA8rSQ3HKlkD0ND7D+m7NUCurkBF1vItPM3K3i
         LO3an+yI2ygh99ga+z/q7+FTZdzQpOC1bSPOQ=
MIME-Version: 1.0
Sender: akarasulu@gmail.com
In-Reply-To: <46E5C9A4-0F65-4D0A-9BB7-279EFD43B629@toolazydogs.com>
References: <4C081B8B.1000700@otego.com>
	<46E5C9A4-0F65-4D0A-9BB7-279EFD43B629@toolazydogs.com>
Date: Sat, 5 Jun 2010 11:35:35 +0300
Message-ID: <AANLkTinSvnyJWhNFYqLVEjhy9c82oepnxAOoBJLy85Sd@mail.gmail.com>
Subject: Re: Exception Logging
From: Alex Karasulu <akarasulu@apache.org>
To: Apache Directory Developers List <dev@directory.apache.org>
Content-Type: multipart/alternative; boundary=001485f1ec20d6d44c0488445267

--001485f1ec20d6d44c0488445267
Content-Type: text/plain; charset=ISO-8859-1

On Fri, Jun 4, 2010 at 3:55 PM, Alan D. Cabrera <list@toolazydogs.com> wro

>
> On Jun 3, 2010, at 2:15 PM, Felix Knecht wrote:
>
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > We have a lot of following constructs:
> >
> > log.error( I18n.err( I18n.ERR_04007 ) );
> > throw new DecoderException( I18n.err( I18n.ERR_04007 ) );
> >
> > What about logging the exception within the exception itself like
> >
> > public DecoderException(String message)
> > {
> >    super( message );
> >    log.error( message );
> > }
> >
> >
> > This will avoid having log.error all over the place and the translation
> > must be done only once instead of twice like above.
>
> This is not a very good pattern for a number of reasons.
>
> First, you cannot control logging at the source of the error.  Admittedly
> this is an error message but I have run into times where I want to turn off
> the klaxon to see what the real problem is.
>
> Second, constructors should not have side effects.  It's never a good idea.
>
> Third, I never log an error if I am throwing an exception.  It just adds
> noise.  I will, however, log additional useful information that is not in
> the exception message.  Just parroting what's in the exception is of little
> value.
>
>
+1


> Finally, what the heck is ERR_04007? :)  I thought there already was a
> discussion and community consensus about how there is little to negative
> value in using numbers as error messages.  Maybe I missed the conversation
> where this opinion was reversed.  If so, ignore this bit.  :)
>
>
+1 - we need to find a way to make this easier to read either with the IDE's
help or other.

-- 
Alex Karasulu
My Blog :: http://www.jroller.com/akarasulu/
Apache Directory Server :: http://directory.apache.org
Apache MINA :: http://mina.apache.org
To set up a meeting with me: http://tungle.me/AlexKarasulu

--001485f1ec20d6d44c0488445267
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 4, 2010 at 3:55 PM, Alan D. Cabrera <span dir=3D"ltr">&lt;<a hr=
ef=3D"mailto:list@toolazydogs.com">list@toolazydogs.com</a>&gt;</span> wro<=
br><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class=3D"im"><br>
On Jun 3, 2010, at 2:15 PM, Felix Knecht wrote:<br>
<br>
&gt; -----BEGIN PGP SIGNED MESSAGE-----<br>
&gt; Hash: SHA1<br>
&gt;<br>
&gt; We have a lot of following constructs:<br>
&gt;<br>
&gt; log.error( I18n.err( I18n.ERR_04007 ) );<br>
&gt; throw new DecoderException( I18n.err( I18n.ERR_04007 ) );<br>
&gt;<br>
&gt; What about logging the exception within the exception itself like<br>
&gt;<br>
&gt; public DecoderException(String message)<br>
&gt; {<br>
&gt; =A0 =A0super( message );<br>
&gt; =A0 =A0log.error( message );<br>
&gt; }<br>
&gt;<br>
&gt;<br>
&gt; This will avoid having log.error all over the place and the translatio=
n<br>
&gt; must be done only once instead of twice like above.<br>
<br>
</div>This is not a very good pattern for a number of reasons.<br>
<br>
First, you cannot control logging at the source of the error. =A0Admittedly=
 this is an error message but I have run into times where I want to turn of=
f the klaxon to see what the real problem is.<br>
<br>
Second, constructors should not have side effects. =A0It&#39;s never a good=
 idea.<br>
<br>
Third, I never log an error if I am throwing an exception. =A0It just adds =
noise. =A0I will, however, log additional useful information that is not in=
 the exception message. =A0Just parroting what&#39;s in the exception is of=
 little value.<br>

<br></blockquote><div><br></div><div>+1</div><div>=A0</div><blockquote clas=
s=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;pad=
ding-left:1ex;">
Finally, what the heck is ERR_04007? :) =A0I thought there already was a di=
scussion and community consensus about how there is little to negative valu=
e in using numbers as error messages. =A0Maybe I missed the conversation wh=
ere this opinion was reversed. =A0If so, ignore this bit. =A0:)<br>

<br></blockquote><div><br></div><div>+1 - we need to find a way to make thi=
s easier to read either with the IDE&#39;s help or other.=A0</div></div><br=
>-- <br>Alex Karasulu<br>My Blog :: <a href=3D"http://www.jroller.com/akara=
sulu/">http://www.jroller.com/akarasulu/</a><br>
Apache Directory Server :: <a href=3D"http://directory.apache.org">http://d=
irectory.apache.org</a><br>Apache MINA :: <a href=3D"http://mina.apache.org=
">http://mina.apache.org</a><br>To set up a meeting with me: <a href=3D"htt=
p://tungle.me/AlexKarasulu">http://tungle.me/AlexKarasulu</a><br>


--001485f1ec20d6d44c0488445267--