Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Received-SPF: pass (athena.apache.org: domain of elecharny@gmail.com
 designates 209.85.160.178 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:reply-to:user-agent:mime-version:to:subject
         :references:in-reply-to:content-type:content-transfer-encoding;
        b=k7MmBbT6pfShyEFiZneLD6K+2O7DsN9JEOSDTOVdCdKaXAnOW87ICwrK+n4NsWzXeI
         BZ8Qer1hTOdZy+FdvSBV0KBYxSgYebZPWsfLuqf7emoJeVh/cBgxIJAk1S5FuM6lpFV5
         kypJj1GtdOMI1GcKAvTwO4jboZAKdSCaE7yuQ=
Message-ID: <4C0BEF5A.6040801@gmail.com>
Date: Sun, 06 Jun 2010 20:56:26 +0200
From: Emmanuel Lecharny <elecharny@gmail.com>
Reply-To: elecharny@apache.org
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US;
 rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4
MIME-Version: 1.0
To: Apache Directory Developers List <dev@directory.apache.org>
Subject: Re: svn commit: r951912 - in /directory/apacheds/trunk:
 protocol-ntp/src/test/java/org/apache/directory/server/ntp/NtpITest.java
 server-xml/ xbean-spring/
References: <20100606173956.0417923888E8@eris.apache.org>
 <4C0BE27E.2000504@apache.org> <4C0BE3AA.2020400@gmail.com>
 <4C0BE61D.6060007@apache.org>
In-Reply-To: <4C0BE61D.6060007@apache.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 6/6/10 8:17 PM, Stefan Seelmann wrote:
> Emmanuel Lecharny wrote:
>    
>> On 6/6/10 8:01 PM, Stefan Seelmann wrote:
>>      
>>>        
>>>> @@ -74,6 +75,7 @@ public class NtpITest
>>>>         * @throws Exception if there are errors
>>>>         */
>>>>        @Test
>>>> +    @Ignore
>>>>        public void testNtp() throws Exception
>>>>        {
>>>>            InetAddress host = InetAddress.getByName( null );
>>>>
>>>>
>>>>          
>>> Is this intended? I though I fixed this test yesterday, is it still
>>> failing?
>>>
>>>        
>> No, sorry, it was caught in a big commit I did. I will revert it
>> immediately.
>>
>> Btw, what was the problem ?--
>>      
> The test asserted two things:
>
> - the delay is in range 0..1000 ms, both bounds excluded. But the delay
> could be 0, especially when getting the time from localhost without any
> network roundtrip. So I included the 0 as valid value.
>
> - the offset is in range 0..1000 ms, both bounds excluded. But the
> offset can be negative. Now the test checks that offset is in range
> -1000..1000 ms.
>    
Doh...

yeah, smart. I didn't thought it can be such a simple problem...

Thank for the fix Stefan !


-- 
Regards,
Cordialement,
Emmanuel Lécharny
www.nextury.com