Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 60813 invoked from network); 4 Jun 2010 12:54:19 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 4 Jun 2010 12:54:19 -0000 Received: (qmail 58918 invoked by uid 500); 4 Jun 2010 12:54:19 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 58828 invoked by uid 500); 4 Jun 2010 12:54:19 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 58819 invoked by uid 99); 4 Jun 2010 12:54:19 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Jun 2010 12:54:19 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.9] (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 04 Jun 2010 12:54:17 +0000 Received: (qmail 60763 invoked from network); 4 Jun 2010 12:53:54 -0000 Received: from unknown (HELO ?IPv6:::1?) (127.0.0.1) by 127.0.0.1 with SMTP; 4 Jun 2010 12:53:54 -0000 Message-ID: <4C08F761.3040705@apache.org> Date: Fri, 04 Jun 2010 14:53:53 +0200 From: Stefan Seelmann User-Agent: Thunderbird 2.0.0.24 (X11/20100411) MIME-Version: 1.0 To: Apache Directory Developers List Subject: Re: [ApacheDS] Move classes of module core-mock to src/test/java of core-api References: <4C0818EB.8010802@apache.org> <4C0820CA.6040003@gmail.com> <4C0834AD.40203@apache.org> <4C08450C.5050308@gmail.com> <4C08B4E6.3030809@apache.org> <4C08D1D9.1060508@gmail.com> <4C08EB2A.90305@apache.org> <4C08ECF9.8070705@gmail.com> In-Reply-To: <4C08ECF9.8070705@gmail.com> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Emmanuel Lecharny wrote: > On 6/4/10 2:01 PM, Stefan Seelmann wrote: >> >>> So where should we put the mocks ? Core-API as you suggested ? (IMO, if >>> that solve the problem, then +1) >>> >> Yes, this would solve the problem. >> >> Another option that also works: as the mocks are only used by the LDIF >> partition tests we can also move them to src/test/java of >> ldif-partition. I think that's the better option. >> > > What if we want to use those mocks in another module in the near (or not > so near) future ? > > Wouldn't it be better to just let the mock be accessible by moving them > in core-api? > > (playing devil's advocate here...) Should I bring another option into the game: Using a mock framework like EaseMock or Mockito? Let's keep it simple. It isn't a big difference to move them to core-api or ldif-partition. The latter option is just a bit simpler to solve the current problem. But I agree with you, moving them to core-api makes it easier to reuse the mocks. Kind Regards, Stefan